Closed (fixed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
base system
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Oct 2020 at 18:04 UTC
Updated:
11 Nov 2020 at 08:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottComment #3
alexpottComment #4
andypostNot sure it's good idea to remove this check, how come that controller is not callable?
maybe just improve defaults for controller? or it's because core using magic strings to define callables?
Comment #5
alexpott@andypost see https://3v4l.org/21CAr - it's not callable without instantiating the class.
Comment #6
andypostYes, it should be removed because controller needs resolver to make sure the callable is valid
According to https://www.drupal.org/node/2092643 controller could be
service.name:[method]so this assertion will fail againComment #7
andypostIt could use https://3v4l.org/k4aD0 but looks better to remove or replace with something that testing exact result
Comment #10
catchCommitted/pushed to 9.2.x and cherry-picked to 9.1.x, thanks!