CommentFileSizeAuthor
#4 interdiff-3178960-4.txt1.29 KBjigish.addweb
#4 3178960-4.patch16.49 KBjigish.addweb
#2 3178960-2.patch16.16 KBjigish.addweb

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Issue summary: View changes
StatusFileSize
new 3178960-2.patch16.16 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3178960-4.patch16.49 KB
new interdiff-3178960-4.txt1.29 KB

@yas

I changed openstack.native to openstack.rest as per our discussion.

Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 3.0.0-beta1 » 3.x-dev
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the refactoring. It looks good to me. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed b952bde on 8.x-2.x authored by jigish.addweb 
    Issue #3178960 by jigish.addweb, yas: Refactor OpenStackEc2Service

  • yas committed 03ca9d2 on 3.x authored by jigish.addweb 
    Issue #3178960 by jigish.addweb, yas: Refactor OpenStackEc2Service
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.