In certain circumstances the noscript code can make the page look rather broken as it's inserted before the form code. It may also be preferable to insert the message into the form itself.
Provide an option to make the noscript code output as a suffix instead of a prefix on the form, or as a form element.
Provide a patch.
The noscript output could be rendered after the form instead of before.
New variable.
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3178167-test.png | 91.69 KB | danrod |
| #5 | antibot-n3178167-5.patch | 3.5 KB | quondam |
| #3 | antibot-n3178167-3.patch | 2.56 KB | damienmckenna |
| #2 | antibot-n3178167-2.patch | 2.07 KB | damienmckenna |
Comments
Comment #2
damienmckennaThis provides an option to control whether the code addition is done via #prefix (default) or #suffix.
Comment #3
damienmckennaThis provides another option that renders the message as a form element, which works fairly well with this change to antibot-no-js.tpl.php:
form.antibot .form-item, form.antibot .form-submit { height: 0; margin: 0; visibility: hidden !important; }Comment #4
damienmckennaThe last patch breaks forms which Antibot is added to.
Comment #5
quondam commented@DamienMcKenna looks like your last patch was breaking forms because the inline element that was being inserted into the form was overriding the
$form['antibot']element, which had an identical array key. Renaming that inline markup`antibot_inline`resolved that naming conflict.The existing inline CSS in the template file was hiding entire forms by default - which also suppressed all child elements inside the form. I've refactored those styles to accommodate the two markup structures rendered by D7 core so that only children of the form that aren't
<noscript>tags are hidden.Finally, I noticed that including a hash in the array keys for the options in the new placement selection in the admin form was preventing the labels for the radio buttons from rendering. Those have been stripped out of the admin form, then re-added via string concatenation after the config variable is retrieved by
antibot_form_pre_render()Comment #6
danrodI'm looking into this again, given that many sites still uses the 7.x release: https://www.drupal.org/project/usage/antibot
Applied the patch cleanly, worked fine for me:
Tested with a form and had no issues, I'll move it to RTBC
Comment #7
danrodComment #8
danrodComment #9
danrod