In #2450227: Ignore parent terms in facets when operator is OR SearchApiFacetapiTerm::execute() parent items were ignored if a child is active when a facet uses the OR operator in an hierarchical structure, since by default entities are tagged with both parent and child terms in hierarchical taxonomies, thus making filtering on the parent include too many results. However, the existing code does not correctly strip parents when using a hierarchical structure with non-numeric machine names, since it checks for the "missing value" filter ! by looking for any non-numeric value.
Check explicitly for the string '!' to exclude the missing value filter, and not any non-numeric value.
Write tests?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | search_api-3178035-allow-non-numeric-filter-names.patch | 833 bytes | mvc |
Comments
Comment #2
mvcComment #3
drunken monkeyThanks a lot for reporting this problem! Very strange that I used
is_numeric()instead of just checking for'!'– the latter seems not only more accurate but also faster.Apparently, we initially (in #2450227: Ignore parent terms in facets when operator is OR) made the mistake of assuming that the
SearchApiFacetapiTermclass was only used for taxonomy terms, while “term” there refers to just any single value. We fixed that in #2703675: Undefined index: [value in taxonomy_term_load error, but apparently overlooked this remaining assumption that all filters would either be integers (taxonomy term IDs) or the missing filter. (Still unclear, though, why I thought this was a good idea either way.)Anyways, so much for the history. Your fix looks great, though, in any case, so I’ll just commit it. (Test coverage is very poor in our D7 code anyways, unfortunately, so no need to bother with that.)
Thanks again!