New deprecation at 9.1

10x: StatementWrapper::fetchColumn should not be called in drupal:9.1.0 and will error in drupal:10.0.0. Access the client-level statement object via ::getClientStatement(). See https://www.drupal.org/node/3177488

    6x in SchedulerRevisioningTest::testRevisioning from Drupal\Tests\scheduler\Functional
    2x in SchedulerRulesActionsTest::testPublishOnActions from Drupal\Tests\scheduler\Functional
    2x in SchedulerRulesActionsTest::testUnpublishOnActions from Drupal\Tests\scheduler\Functional

Change record https://www.drupal.org/node/3177488

CommentFileSizeAuthor
#6 3177933-6.patch6.03 KBPooja Ganjage
#3 3177933-3.patch2.44 KBPooja Ganjage

Comments

jonathan1055 created an issue. See original summary.

  • jonathan1055 committed f2eb5b7 on 8.x-1.x 
    Issue #3177933 by jonathan1055: Allow for 10x StatementWrapper::...
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3177933-3.patch2.44 KB

Hi,

Creating patch for this issue.

Please review the patch.

Let me know if any suggestions.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 3177933-3.patch, failed testing. View results

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3177933-6.patch6.03 KB
Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
jonathan1055’s picture

jonathan1055 commented

Thanks for starting this. Could you explain why you are calling @trigger_error in the Scheduler tests? Also patch #6 does not contain any of the changes from patch #3.

jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

Patch #3 was completely wrong. Patch #6 did not solve the deprecation either.

I have now fixed this as part of #2096585: Support for non-node entities, e.g. Media, Commerce Products, Custom 3rd-party entities. The solution is to replace ->fetchColumn() with ->fetchField()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.