I just saw that the Drupal 8 version has a checkbox "Enable cookie(s) automatic-removal when consent isn't given." to enable / disable the auto cookie removal completely. This would also be very helpful in the Drupal 7 version. All other options seem be be equal but this one seems to be missing.

This is how it looks like in 8.x-1.x, while the checkbox is missing in 7.x-1.x:
eucc cookie auto removal button

CommentFileSizeAuthor
#8 d7_eucc_backport_automatic_cookie_removal-3177170-8.patch4.96 KBanybody
#7 d7_eucc_backport_automatic_cookie_removal-3177170-7.patch4.11 KBanybody
#2 eucc_d8-cookie-removal.PNG6.38 KBanybody

Issue fork eu_cookie_compliance-3177170

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
StatusFileSize
new eucc_d8-cookie-removal.PNG6.38 KB
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
svenryen’s picture

svenryen commented

We stopped porting patches to D7 if there wasn't a D7 patch provided in the issue :)
You can compare the release notes/changelogs to see which issues didn't get ported to D7.

So feel free to port and upload a patch.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » anybody

Thanks, yep I completely understand that and will do it asap as the time allows! :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

As we've run into a critical customer issue with it today combined with Drupal Commerce checkout (paypal seems to set cookies) we have a good chance for the feature implementation patch today ;)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review
StatusFileSize
new d7_eucc_backport_automatic_cookie_removal-3177170-7.patch4.11 KB

Sorry, playing around with the issue forks. Let's use the attached patch for now...
Ready for review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
StatusFileSize
new d7_eucc_backport_automatic_cookie_removal-3177170-8.patch4.96 KB

Found a missing exposed js variable.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Minor » Normal

@svenryen: #8 is ready for your review, I just tested the different combinations and the update and everything works fine. The previous default (auto deletion enabled) is kept.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

PS//off topic @svenryen: Are you able to delete the forks here? I couldn't find something about that in the documentation. They are wrong because I made a mistake.

svenryen’s picture

svenryen commented

I don't think we can delete issue forks, but it should do no harm leaving them there.

  • svenryen committed afa8b65 on 7.x-1.x authored by Anybody 
    Issue #3177170 by Anybody, svenryen: [7.x-1.x] Backport cookie removal...
svenryen’s picture

svenryen commented
Assigned: anybody » Unassigned
Status: Needs review » Fixed

Thanks for the patch! Reviewed it now and looks great.

  • svenryen committed afa8b65 on 7.x-2.x authored by Anybody 
    Issue #3177170 by Anybody, svenryen: [7.x-1.x] Backport cookie removal...
  • svenryen committed d6464b0 on 7.x-2.x
    Merge branch '7.x-1.x' into 7.x-2.x

* 7.x-1.x:
  Issue #3178091 by...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.