Problem/Motivation

In current dev version is too big amount of coding standarts issues.
Needs to fix it.

Proposed resolution

To provide a patch that should fix that isses.

CommentFileSizeAuthor
#5 3177136-5.patch19.5 KBaleevas
#3 3177136-3.patch19.23 KBaleevas
#2 3173772.patch582 bytesaleevas

Comments

aleevas created an issue. See original summary.

aleevas’s picture

aleevas
he/him
Primary language Russian
commented
StatusFileSize
new 3173772.patch582 bytes

Here is a patch for solving the issues.

aleevas’s picture

aleevas
he/him
Primary language Russian
commented
StatusFileSize
new 3177136-3.patch19.23 KB

Uh, seems to I made mistake and attached wrong file.
This one should be more fit.
Sorry!

aleevas’s picture

aleevas
he/him
Primary language Russian
commented
Status: Needs review » Postponed

Looks like we don't need this patch before the module became to stable version.
So better to postpone it now

aleevas’s picture

aleevas
he/him
Primary language Russian
commented
Status: Postponed » Needs review
StatusFileSize
new 3177136-5.patch19.5 KB

I think that now is the better time to make changes accordingly to Code Standards.
So here my patch

hamrant’s picture

hamrant commented
Status: Needs review » Reviewed & tested by the community

Looks ok for me

  • hamrant committed 9800f8b on 8.x-2.x authored by aleevas 
    Issue #3177136 by aleevas, hamrant: Coding standarts issues
hamrant’s picture

hamrant commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.