Meeting of the Bug Smash Initiative 2020-10-27 [#3176994]

Agenda items

Standing items

Who is here
Any other suggested topics
Wins / Thanks / Blockers
Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
The bug I would most like to see fixed
Update on target items from last meeting
What should be the initiative focus for the next 2 weeks?

New items

Possible Goole Meet triage, perhaps the week this meeting is not scheduled.

ToDos

anyone: test 9.1.0-beta1 scheduled to be released November 4. See #3
anyone: review implementation approach on #2623254: Menu link edit & delete routes do not retain the current language
anyone: revie final discsion #86287: Password reset process ignores the user's language preference
mohit_aghera: speak to Gabor about #3067007: LanguageNegotiationUrlFallback should use content language for TYPE_URL fallback

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

pameeela	:wave: Pam, Noosa, AU
mohit.aghera	Mohit, Ahmedabad, India
larowlan	Lee, Australia :koala:
Griffyn Heels	Griff, Melbourne, Aus :doughnut:
Michael (g-brodiei)	Michael, TaiwanCongrats to two days of zero cases in Melbourne!
quietone	Victoria, Nz
hansa11	:wave: Hansa, India
Kristen Pol (she/her)	Kristen, Central California, late
lendude	Len, Amsterdam, sleepy
Paulo Henrique Cota Starling	Paulo Henrique (paulocs) - Belo Horizonte, Brazil
dww	Derek, US

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

pameeela	Anyone interested in doing Google Meet triage? We tried it once and it went well, but not sure whether there is interest in doing it again.
pameeela	Do we want to add alpha / beta testing of 9.1.0 as a target? per x_jm's suggestion (edited)
Griffyn Heels	Is there can we do about the Olivero bugs? Its throwing out our smashed statistics!
larowlan	We have a code sprint next week for DrupalGov, any targets - pls use ‘DrupalGov 2020’ tag
Michael (g-brodiei)	What's the life turning movie you'd like to share?
quietone	Issue summary quality

2️⃣.1️⃣ Wins - what wins have you had this fortnight - share your successes!

quietone	Not in Bug Smash but this is now closed, #2208401: [META] Remaining multilingual migration paths and I feel much better :smile:
lendude	Actually found a little time to do core stuff again, that will change the coming weeks :shrug:

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you this fortnight

mohit.aghera	Thanks to @quietone for all the help and valuable suggestions
larowlan	thanks to @Griffyn Heels for running this meeting again
Michael (g-brodiei)	Thanks to @jonathanjfshaw for the help on reviewing bugs and constructive feedback!!Thanks to this friendly community who has shown their support on hearing out even by a simple emoji makes the day shine :sunny:

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals

mohit.aghera	Needs some eyes on implementation approach for #2623254: Menu link edit & delete routes do not retain the current language#comment-13860318 Comment #20 and #23 (edited)
larowlan	I think comment #18 there was missed too
larowlan	DI can be done in a BC way fwiw
larowlan	Time! is my blocker
mohit.aghera	@larowlan, so the current approach seems good then?I can review test case failures.
larowlan	@mohit.aghera does the current patch address comment 18?
mohit.aghera	Yes, it addresses the suggestions from #18. I’ve updated few test cases as well.
mohit.aghera	In #23 i’ve updated few test cases to cover the changes. There is one failures so i’ll review it.
mohit.aghera	[#3067007]Any thoughts how we write test cases for it?I tried one approach using content language, but this doesn’t seem to be working..I’m not entirely convinced with the approach. (edited)
larowlan	not my area of expertise there, I’d ask Gabor
Michael (g-brodiei)	We need to have a discussion and final decision of the reset email's content behaviour to push this issue forwardhttps://www.drupal.org/project/drupal/issues/86287 (edited)
Kristen Pol (she/her)	Feels like all that is 2020 is my blocker. Need to clear the cache and start fresh.
Paulo Henrique Cota Starling	Writing tests in general is my problem. I see that I spend to much time trying to write tests. Two issues I tried to write test for:[#2470896]The last one is almost the same case from the one that @mohit.aghera mentioned above. (edited)
mohit.aghera	Thanks for pointing @Paulo Henrique Cota StarlingI see that you have added relevant comments and other test cases, do you want me to review or add test cases for those?
Paulo Henrique Cota Starling	Yes, I would appreciate it. If you have any question, you can ask me. You can choose the issue you feel more comfortable to work on.

3️⃣ Core bug statistics - current state of open bugs

larowlan	73 smashed, 73 opened. The opened ones include Olivero
dww	That's actually not bad that we broke even the week that Olivero's bugs were added. ;)

4️⃣ Nominate your pet issue for a bug-smash target for the next fortnight

mohit.aghera	#3067007: LanguageNegotiationUrlFallback should use content language for TYPE_URL fallback (edited)
Kristen Pol (she/her)	This is marked a task and not sure if it is a bug but I'm so tired of seeing my inbox notifications for this one. #2994928: Quote consistency in .info.yml files for Core modules
dww	I've carved some time in my work schedule to try to make real progress on Update Manager issues over the next two weeks. If anyone's interested in helping out, please ping me here and I'd be happy to discuss specifics, issues, what kind of help is needed where, etc. Thanks!Some specific issues I'm aiming to work on:#3132426: Notice: Undefined index: title in Drupal\update\ProjectSecurityRequirement (edited)
larowlan	tag them as DrupalGov 2020 and I’ll see if we can get any takers at next week’s sprint

5️⃣ Help me - Is there anything you could use a :hand: with?

Kristen Pol (she/her)	Note: Some of these ended up in the blocker thread.
dww	Heh, I just posted some of these to 4️⃣ , also. ;)

6️⃣ @pameeela: "Anyone interested in doing Google Meet triage? We tried it once and it went well, but not sure whether there is interest in doing it again."

Griffyn Heels	Yep definitely, would love some more guidance as a non-dev.
quietone	Yes
Michael (g-brodiei)	Yes! If time allows I'll join!
larowlan	this would fit well with next week’s code sprint too
pameeela	should we set some up during the sprint?
pameeela	i think we can set up breakout sessions for people who are keen but not sure where to start. e.g. i can flag a bunch of issues to be tested to see if they can still be reproduced, from simple to more complicated.
larowlan	yeah that would help
larowlan	perhaps we should set a recurring time for this? could be the alternating week to the meeting
Kristen Pol (she/her)	I am interested if I'm able
lendude	Would love to join if by some miracle it is at a time I’m awake/able :wink:
pameeela	it's only 4:30pm QLD time right now, is this usually an OK time for you?
lendude	This is 7:30 am while having breakfast with the kids, easier to type some slack replies then actively talking on an Meet :smile: but yeah I could make it work, don’t plan for me though, lots of things tend to throw my planning off
Paulo Henrique Cota Starling	On 4:30pm QLD is 03:30am in Brazil. I think I'll not be awake at this time...

7️⃣ @pameeela "Do we want to add alpha / beta testing of 9.1.0 as a target? per x_jm's suggestion"

lendude	Do we have some docs on ‘how’ for this?
pameeela	#3177224: [meta] 9.1.0 beta testing summarises the beta testing program.

8️⃣ @Griffyn Heels "Is there can we do about the Olivero bugs? Its throwing out our smashed statistics!"

pameeela	yeah, help fix them :joy:
Griffyn Heels	haha, bugger.
Michael (g-brodiei)	Hahaha
Kristen Pol (she/her)	We could report stats with and without to see the trend

9️⃣ @larowlan "We have a code sprint next week for DrupalGov, any targets - pls use ‘DrupalGov 2020’ tag"

larowlan	I’ve already tagged some of the really old issues
Kristen Pol (she/her)	What might be good targets? Novice and simple ones? (edited)
lendude	I have a code sprint and giving an automated testing workshop for core in a week and a half, so I might look at the ones you have tagged too (might focus on the ones tagged ‘needs tests’)
larowlan	there is a mix of people there, so a broad range is fine
dww	Are there more details on the sprint? Wondering about time(zone), day(s), "where", etc. Might be able to plug in if it all works out for scheduling.
larowlan	https://www.previousnext.com.au/blog/join-us-drupalgov-2020-code-sprint I’d say 9.30 am - 4.30 PM GMT+11
larowlan	so that would be 12.30-7.30 in your TZ assuming your slack TZ is accurate
larowlan	this time next week there will be ~1.5 hours to go
dww	Thanks!
dww	Hah, yeah, that's during the US election. ;) Not that we're likely to know much that day, but it'll probably be somewhat hard to concentrate on Drupal code...
larowlan	yeah, I remember the last one. I hit reload so many times and it just got worse
Kristen Pol (she/her)	I think it might be a welcome distraction from the election

1️⃣ 0️⃣ @Michael (g-brodiei) "What's the life turning movie you'd like to share?"

larowlan	Can I list a book instead? They made a movie of it. And a song. (edited)
Griffyn Heels	A classic that definitely shook me when I saw it a lot time ago was The Truman Show (edited)
Michael (g-brodiei)	@larowlan, would love to hear about it!
larowlan	I made some big life decisions based on the themes of that book :slightly_smiling_face:
Michael (g-brodiei)	One that changed my living attitude was Pay it foward and Patch Adams when I saw it as a kid (edited)
larowlan	now I feel old
Michael (g-brodiei)	@Griffyn Heels Truman show was quite a classic, maybe I'll get a new inspiration to watch it again after years
pameeela	I am struggling to think of something profound, but to be honest, what comes to mind is the spectacularly ridiculous/brilliant film "Waiting for Guffman".
Kristen Pol (she/her)	I have nothing profound to offer but I love The Princess Bride. I "met" Cary Elwes at a ComicCon and he seemed super nice. It was funny too because he was wearing blue medical gloves for the photo shoots. I assume he was trying to keep the germs down. Seems prescient with the mask in the movie and gloves in the crowds. (edited)
Kristen Pol (she/her)	I love The Truman Show too as do my teenage kids. Not sure I've seen the other ones mentioned though I probably read The Stranger in school eons ago.
lendude	Gotta go with Billy Elliot, fantastic movie, fantastic soundtrack, fantastic first date with the girl that I’m still with 20 years later :slightly_smiling_face:
larowlan	T-Rex on that soundtrack right?
lendude	Yeah and The clash and for me it’s the riot scene with A Town Called Malice playing that really pops

1️⃣ 1️⃣ @quietone "Issue summary quality"

quietone	There is such a range on these it is hard to know when to tag something as needs summary update.
quietone	For example, should screens shots always been in the IS? I think so as it save hunting around for them,
quietone	Sometimes I think it would help to have a couple of high quality issue summaries to point people to as examples.
pameeela	For example, should screens shots always been in the IS? I think so as it save hunting around for them,definitely, if there are screenshots that are useful. but i think it's probably just as easy to update this myself when i see it, rather than tagging (edited)
pameeela	i will usually only use the tag if i know it needs an update, and i know that i can't do a reasonably good job of it.
pameeela	@quietone have you seen the different IS templates? there is one specifically for "visual issues" https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-...
larowlan	For me when I look at issue summaries. I want the ‘proposed resolution’ to match what I’m seeing in the patch, and on long issues - to summarize the 100s of comments
quietone	@pameeela no I hadn't seen those templates. Thx for that.
Michael (g-brodiei)	The only reason I won't put image on issue summary is because it makes the issue soooo long when it's multiple image stacking one over another. If we can collapse them, it looks neater.I'd tag/update issue summary update when the final solution/discovery of issue doesn't match the original descriptions.
Michael (g-brodiei)	Should we have a status/tag or update the issue summary for issues that is still under discussion? So it's easier to allocate feedback and comments?I'm experiencing some issues that are still awaiting decisions (but there isn't a consensus over time....), so it's on hold for months or years
quietone	I think so. That is the Issue Summary should be up to date, even if work is waiting for a decision. The IS should make it what decision is being made and the various options.
pameeela	yeah the thing about the issue summary update is that it's in the best interest of ticket progress, rather than just a box to tick. kind of like steps to reproduce - it can feel a bit like a chore but it ends up moving the issue along. so @Michael (g-brodiei) i would encourage you to try to update ones needing a decision in order to get a faster decision. the first thing I thought when i saw #86287 was "needs an issue summary update" !
Michael (g-brodiei)	@pameeela Got it! will do!!! I'll update the current summary as I see fit then. Maybe with a headline as "current discussion status" is good and clear?
pameeela	yes sure or that can go under "Proposed resolution"? with "Confirm approach" as a remaining task?
pameeela	that is what i usually do
Michael (g-brodiei)	Hmmmm, okay. I'm just afraid I will end up a page length essay LoL.
quietone	Even so, that will be easier for a reviewer than reading 100+ comments
Michael (g-brodiei)	Hahaha, okay, I get the picture :rolling_on_the_floor_laughing: . It's just the same as why we added the template to the issue creator in the first place, accurate information is top priority. :muscle:
Kristen Pol (she/her)	I like the idea of finding a couple/few particularly good issue summaries for examples and adding them to the bugsmash documentation

That’s a wrap folks, this Bugsmash meeting is over. Thanks all for coming!Please feel free to keep chatting in the threads. They'll be active for about 24 hours before saving to d.o

Michael (g-brodiei)	Thank you all~
Kristen Pol (she/her)	Thanks!

Participants:

pameeela, mohit.aghera, larowlan, Griffyn Heels, Michael (g-brodiei), quietone, hansa11, Kristen Pol, lendude, Paulo Henrique Cota Starling, dww

Comments

Comment #1

14 October 2020 at 22:39

quietone created an issue. See original summary.

Comment #2

14 October 2020 at 22:39

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #3

xjm

she/her

English

commented 22 October 2020 at 16:20

I'm not usually awake myself for meetings, but à propos: 9.1.0-alpha1 will be released today-ish and 9.1.0-beta1 will be released November 4. Maybe we could have joining the beta testing program as a suggested goal for that fortnight?