Toolbar menu icons not displayed when active

Hello @Pnoia,
I've checked this issue in my local setup but I've not found the toolbar icon missing on active state.

Can you please find attached screenshot for the same.

Thanks

Hi @Dharti Patel I am reviewing #3

I've checked this issue no icon missing

This is an issue in D10.

1. E.g. the adminimal_theme/css/adminimal.css at line 759 looks for icons at given path e.g. /core/themes/stable/images/core/icons/787878/puzzlepiece.svg and it gives 404.
2. It's because there is no /stable/ because it has been removed https://www.drupal.org/node/3309392
3. The right path to the icon is e.g. /core/misc/icons/787878/puzzlepiece.svg

Also the correct structure and pathing for the icons should be followed as shown here https://api.drupal.org/api/drupal/core!themes!stable9!css!toolbar!toolba... (under View Source) instead of absolute URL that breaks local/sub dir installations, which would also solve this: https://www.drupal.org/project/adminimal_theme/issues/2658148

E.g. go from Adminimal's:

.adminimal .toolbar-icon-system-themes-page:active::before, .adminimal .toolbar-icon-system-themes-page.is-active::before {
	background-image: url(/core/themes/stable/images/core/icons/787878/paintbrush.svg);
}

To toolbar.icons.theme.css format:

.toolbar-icon-system-themes-page::before {
	background-image: url(../../../../misc/icons/787878/paintbrush.svg);
}

Replace the absolute /core/themes/stable/images/core/icons/787878/ with ../../../../misc/icons/787878/

Created patch for toolbar menu icons issue.
Kindly review.

Regards!

Patch works. Thanks.

Noticed "page not found" errors with Adminimal trying to use the core stable paths for the icons. #9 patch fixed it nicely

This issue is related to Drupal 10.
Please check the below steps to reproduce this issue

1. Install Drupal 10.
2. Add "Adminimal" as an administration theme.
3. Now click on "Structure", for the active menu items, the icons of the toolbar aren't displaying.

It's because there is no stable theme existing in the core folder.

So we need to update the background image path instead of "/core/themes/stable/images/core/icons/787878/file.svg" need to update "/core/misc/icons/787878/file.svg".

Please check the below code with the updated path.

/* Main menu icons. */
.adminimal .toolbar-icon-system-admin-content:active:before,
.adminimal .toolbar-icon-system-admin-content.is-active:before {
  background-image: url(/core/misc/icons/787878/file.svg);
}

.adminimal .toolbar-icon-system-admin-structure:active:before,
.adminimal .toolbar-icon-system-admin-structure.is-active:before {
  background-image: url(/core/misc/icons/787878/orgchart.svg);
}

.adminimal .toolbar-icon-system-themes-page:active:before,
.adminimal .toolbar-icon-system-themes-page.is-active:before {
  background-image: url(/core/misc/icons/787878/paintbrush.svg);
}

.adminimal .toolbar-icon-entity-user-collection:active:before,
.adminimal .toolbar-icon-entity-user-collection.is-active:before {
  background-image: url(/core/misc/icons/787878/people.svg);
}

.adminimal .toolbar-icon-system-modules-list:active:before,
.adminimal .toolbar-icon-system-modules-list.is-active:before {
  background-image: url(/core/misc/icons/787878/puzzlepiece.svg);
}

.adminimal .toolbar-icon-system-admin-config:active:before,
.adminimal .toolbar-icon-system-admin-config.is-active:before {
  background-image: url(/core/misc/icons/787878/wrench.svg);
}

.adminimal .toolbar-icon-system-admin-reports:active:before,
.adminimal .toolbar-icon-system-admin-reports.is-active:before {
  background-image: url(/core/misc/icons/787878/barchart.svg);
}

.adminimal .toolbar-icon-help-main:active:before,
.adminimal .toolbar-icon-help-main.is-active:before {
  background-image: url(/core/misc/icons/787878/questionmark-disc.svg);
}

Please check the updated patch. I have added interdiff file to compare #9 patch.

+Needs review

Patch from #12 works nicely and should be preferred over the patch from #9: the latter uses data URIs containing icons which seems unnecessary to me given that the icons reside in /core/misc/icons already. Moving to RTBC.

Side node: the patch from #3 fixes some CSS coding standard violations unrelated to this issue (while also introducing some new violations). These should be addressed separately.

Patch from #12 also works for us, thanks.

Yep, patch #12 also working this side.

Drupal core: 10.1.5
Adminimal Theme: 8.x-1.7

Another thumbs up for #12.

Patch on #12 works like a charm!

There is also a reference to stable within the info.yml file. Here is a patch to map core's system theme to the (now contrib) seven theme. This should be applied alongside #12.

Hi everyone, I made a patch that merge both the #12 one and the #18 one. Works on Drupal 10.3.1 and adminimal_theme 8.x-1.7.

#19 works. Thanks!

Patch #19 doesn't apply cleanly because it was created from a site root.

I've taken the changes and applied them in https://git.drupalcode.org/project/adminimal_theme/-/merge_requests/17

It fixes the problem for me.

Hi, I'm sorry for the mistake! I did it on the go when I was working but I'm happy to know that works!