For example, if you visit the "Appearance" page (admin/appearance), the icon on the toolbar for this menu looks to not be present, but instead has the same colour as the toolbar.

Looking at the css, this will only occur for site run in a sub directly (or in my case locally). The css for these images is:

background-image: url(/core/themes/stable/images/core/icons/787878/file.svg);

But when you run a site in a folder, such as "my-site", the path would then need to be

/my-site/core/themes/stable/images/core/icons/787878/file.svg

CommentFileSizeAuthor
#6 adminimal_theme-css-absolute-urls.patch2.61 KBtobia
#3 admin_theme-active-menu-items-2658148-1.patch1.1 KBArturY
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

iancawthorne created an issue. See original summary.

iancawthorne’s picture

iancawthorne CreditAttribution: iancawthorne commented
Issue summary: View changes
ArturY’s picture

ArturY CreditAttribution: ArturY as a volunteer commented
Title: Toolbar active icons are the same colour as the background colour » Fixed toolbar active submenu items.
Status: Active » Needs review
FileSize
admin_theme-active-menu-items-2658148-1.patch1.1 KB

Hi,
I've made investigation with toolbar submenu links, right now when you select submenu category, active submenu link do not shown as selected and at first look you don't know what category is opened(active), seems to me it's barely intuitive.

I've figured out this issue the way I see it more appropriate for understanding menu navigation structure.
Please check out my improvement.

Thanks.

ozin’s picture

ozin
Primary language Ukrainian
Location 🇺🇦Lviv
CreditAttribution: ozin as a volunteer and commented
Title: Fixed toolbar active submenu items. » Toolbar active icons are the same colour as the background colour
tobia’s picture

tobia CreditAttribution: tobia commented

I don't think ArturY's patch addresses this issue.

The problem is simply that adminimal.css contains some absolute paths: url(/*) which is a big NO-NO in themes, because they break on websites that are not installed in the domain root.

In this case, it's enough to change all 8 instances of url(/core/ into url(../../../core/

tobia’s picture

tobia CreditAttribution: tobia commented
FileSize
adminimal_theme-css-absolute-urls.patch2.61 KB
ANDiTKO’s picture

ANDiTKO CreditAttribution: ANDiTKO as a volunteer commented

@tobia Thanks for the patch and you help!

But what about if the theme is installed in another directory, not in "/themes/adminimal_theme"? like "/sites/mycool_website/themes/adminimal_theme" ...

andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Status: Needs review » Needs work
bskibinski’s picture

bskibinski
Primary language Dutch
Location Breda, The Netherlands
CreditAttribution: bskibinski at ezCompany commented
Status: Needs work » Closed (won't fix)

I think the problem here is not the adminimal theming, but the Drupal site setup of iancawthorne.
/core should always be in the root directory of your site install, I think a lot of modules and themes in drupal 8 are depending on that path structure.

You can have multi-site installs in the /sites directory, but drupal's root should always contain the /core folder. (default 'drupal8 composer install' puts the /core inside the /web folder, so web is your drupal root path.)

I don't think we can fix this issue for every path, without adding multiple fallbacks, and that could bring other unexpected issues, because you would look for images outside of drupal's path for most users.

Did you try the adminimal admin toolbar module? I think this will fix your issue, because it has its own icon with a relative path from the module.

Also, adminimal theme supports overriding theming, so you could fix the path's in your own install. But if you're using version control, I would recommend creating a new subtheme with adminimal as your base theme, and put the fix in there. (don't forget to make the new subtheme de default admin theme).