From @lauriii in #216 in #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

 +++ b/core/themes/olivero/templates/layout/html.html.twig
@@ -0,0 +1,57 @@
+    {{ noscript_styles }}
Let's document [noscript_styles] in the @file documentation.
CommentFileSizeAuthor
#13 3176911-after_patch.png70.32 KBabhijith s
#12 3176911-12.patch533 bytesanmolgoyal74
#9 3176911-9.patch532 bytesmarkdorison
#4 3176911-4.patch533 byteskostyashupenko

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: [Code Review] Document [noscript_styles] in the @file documentation of html.html.twig » [Olivero Code Review] Document [noscript_styles] in the @file documentation of html.html.twig
Project: Olivero » Drupal core
Version: 8.x-1.x-dev » 9.1.x-dev
Component: Code » Olivero theme
Priority: Normal » Minor
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: [Olivero Code Review] Document [noscript_styles] in the @file documentation of html.html.twig » Document [noscript_styles] in the @file documentation of Olivero's html.html.twig
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
StatusFileSize
new 3176911-4.patch533 bytes
ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented

The above patch works fine.RTBC

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
Status: Needs review » Reviewed & tested by the community
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

+1

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3176911-4.patch, failed testing. View results

markdorison’s picture

markdorison
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 3176911-9.patch532 bytes

The patch was no longer applying. Re-rolled.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll
anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs work » Needs review
StatusFileSize
new 3176911-12.patch533 bytes

@lauriii
Patch in #9 applies cleanly on 9.1.x.

I have re-rolled for 9.2.x if needed.

abhijith s’s picture

abhijith s commented
StatusFileSize
new 3176911-after_patch.png70.32 KB

Applied patch #9 and it works for 9.1.x. Also patch #12 works for 9.2.x

after

markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

  • lauriii committed f02a773 on 9.2.x 
    Issue #3176911 by markdorison, kostyashupenko, anmolgoyal74, mherchel:...

  • lauriii committed 59e4518 on 9.1.x 
    Issue #3176911 by markdorison, kostyashupenko, anmolgoyal74, mherchel:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs reroll

Committed f02a773 and pushed to 9.2.x. Also cherry-picked to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.