(re)Ensure that all of Olivero's SVGs are optimized.

Hi,

I am creating a patch for this issue.

Please review the patch.

Let me know for any suggestions.

Thanks.

ImageOptim reports the following SVGs for optimizations:

NW for screenshots

Providing updated patch with re-rolled 9.3.x

Kindly review.

Gulp SVG image optimization report:

Thanks!

Patch #10 applied cleanly for me and all the SVGs got optimized.

Verified and tested patch #10.
Patch applied successfully and looks good to me.

Testing Steps:
# Install Olivero theme
# Download the patch
# Run the command - ls -al (to check the size of SVGs)
# Apply the patch
# Run the command - ls-al (to check the updated size of SVGs)

Expected Results:
# User should see the expected size of SVGs

Actual Results:
# Currently User is able to see the size of SVGs but the size is maximum.

Note: Can be a move to +1 RTBC

Removing the duplicate comments [Ignore]

.

This patch does not apply to 9.3.x - we need to reoptimise the images in that branch...

error: patch failed: core/themes/olivero/images/chevron-down.svg:1
error: core/themes/olivero/images/chevron-down.svg: patch does not apply
error: patch failed: core/themes/olivero/images/search.svg:1
error: core/themes/olivero/images/search.svg: patch does not apply
error: core/themes/olivero/images/select-chevron-bg-default.svg: does not exist in index
error: core/themes/olivero/images/select-chevron-bg-error.svg: does not exist in index
error: core/themes/olivero/images/select-chevron-bg-highlight.svg: does not exist in index

This is a performance and scalability issue, so at least normal and maybe higher depending on the performance impact.

We never really set standards for frontend performance (aside from "any changes should have before-and-after size and number of aggregates posted" which I can't remember the last time I saw in practice), but saving an entire KB seems pretty good, all things considered.

Needs re-roll/rebase

Rerolled for 10.1.x.
Please review.

#23 looks good to me other than rebase as mentioned by #27.

+1 RTBC after re-roll/rebase

@Manoj Raj.R - Screenshots of diffs are not helpful. The patch provides the diff, and the automated testing alerts us to problems like the patch not applying. For this specific issue, screenshots of the reduced filesize, and of the SVGs in use are what is needed to move the issue forward.

@_utsavsharma - Thank you for the updated patch, necessary screenshots are below.

Updated file sizes:

Old vs new icons on various backgrounds:

One issue I am noticing is that we're removing the viewbox attribute in favor of the width & height attributes. I'm not sure that's the way to go as it can interfere with the SVG's internal aspect ratio, causing icons to be clipped when the X/Y dimensions are overridden by CSS.

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.