New coding standard warning in scheduler.module at core 9.1 when using Coder 8.3.10

-------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------
  80 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
 613 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
 702 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
-------------------------------------------------------------------------
CommentFileSizeAuthor
#5 3176832-5.patch1.58 KBPooja Ganjage
#2 3176832-2.patch1.58 KBPooja Ganjage

Comments

jonathan1055 created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3176832-2.patch1.58 KB

Hi,

I am creating a patch for this issue.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Needs work

Hi Pooja,
Thanks for the patch. This problem is not reported at Coder 8.3.9 so does not show up on drupal.org tests. Have you installed Coder 8.3.10 locally? If so, you will see that there are still errors with the lines you have fixed.

The nice thing is that you can use phpcbf to fix the problems automatically.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3176832-5.patch1.58 KB

Hi,

I am creating patch with using phpcs and phpbf commands of coder 8.3.10 version.

@jonathan1055, I have not found any errors in coder 8.3.10 version itself.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
jonathan1055’s picture

jonathan1055 commented

Thanks. Yes patch #5 is correct. You can see the difference - the variable has to be at the end of the declaration.

patch #2

-  /* @var $node \Drupal\node\NodeInterface */
+  /** @var $node \Drupal\node\NodeInterface */

patch #5

-  /* @var $node \Drupal\node\NodeInterface */
+  /** @var \Drupal\node\NodeInterface $node */

jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

Thank you, committed and fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.