Problem/Motivation

php Debug User deprecated function: Theme functions are deprecated in drupal:8.0.0 and
are removed from drupal:10.0.0. Use Twig templates instead of
theme_vbo_export_content_xlsx()

Steps to reproduce

install module in Drupal 9

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 vbo_export-deprecated-theme-functions-3175522-11.patch17.93 KBjacobbell84
#9 vbo_export-deprecated-theme-functions-3175522-9.patch18.62 KBjohnpitcairn
#8 vbo_export-deprecated-theme-functions-3175522-8-interdiff.txt985 bytesjohnpitcairn
#8 vbo_export-deprecated-theme-functions-3175522-8.patch19.68 KBjohnpitcairn
#2 vbo_export-remove-deprecation.patch19.29 KBjacobbell84

Comments

tjtj created an issue. See original summary.

jacobbell84’s picture

jacobbell84 commented
Version: 8.x-3.2 » 8.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new vbo_export-remove-deprecation.patch19.29 KB

I refactored the code to remove the use of the user functions. Tested with CSV and XLSX export and it seems to be working ok.

vm’s picture

vm commented
Title: User deprecated function » deprecated function theme_vbo_export_content_xlsx() should no longer be used

Cleaned up title

jacobbell84’s picture

jacobbell84 commented
johnpitcairn’s picture

johnpitcairn commented

There appear to be a lot of unrelated changes in the patch? OK I see what you've done, moved the output generation logic that was previously in theme functions directly into the plugin. Makes sense, will test.

johnpitcairn’s picture

johnpitcairn commented
Status: Needs review » Needs work

VboExportXlsx.php is missing a use Drupal\Core\Form\FormstateInterface statement.

johnpitcairn’s picture

johnpitcairn commented

Actually, I think VboExportXlsx::buildPreConfigurationForm() which uses FormStateInterface is not required, since there is no need to configure separators for xlsx export. The parent method in the base class should be sufficient.

johnpitcairn’s picture

johnpitcairn commented
Status: Needs work » Needs review
StatusFileSize
new vbo_export-deprecated-theme-functions-3175522-8.patch19.68 KB
new vbo_export-deprecated-theme-functions-3175522-8-interdiff.txt985 bytes

Patch with unnecessary xlsx separator pre-configuration form removed, and interdiff.

johnpitcairn’s picture

johnpitcairn commented
StatusFileSize
new vbo_export-deprecated-theme-functions-3175522-9.patch18.62 KB

Ack. Try this one.

johnpitcairn’s picture

johnpitcairn commented
Status: Needs review » Needs work

Patch will now need a reroll for current dev.

Not sure I can be bothered since nobody marked it RTBC and it wasn't committed for the latest update. Somebody else can deal with it when D10 support is required.

jacobbell84’s picture

jacobbell84 commented
Status: Needs work » Needs review
StatusFileSize
new vbo_export-deprecated-theme-functions-3175522-11.patch17.93 KB

I did a quick re-roll. Includes some cleanup that got missed in the first few patches.

johnpitcairn’s picture

johnpitcairn commented

Thanks! Working as expected. Now we just need somebody who didn't work on it to RTBC.

graber’s picture

graber commented
Status: Needs review » Reviewed & tested by the community

Nice :)

  • Graber committed 3accb84 on 8.x-3.x authored by jacobbell84 
    Issue #3175522 by John Pitcairn, jacobbell84: deprecated function...
graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.