Problem/Motivation

The codebase throws a lot of messages in the PhpStorm inspection tool.

Proposed resolution

We should go through these and improve the quality of the code before releasing 1.33.

A report can be gathered in PhpStorm, and also the output has been attached here for convenient reference.

CommentFileSizeAuthor
#8 eu_cookie_compliance-code-improvements-before-releasing-1.33-3174558-6.patch25.29 KBsvenryen
#5 eu_cookie_compliance-code-improvements-before-releasing-1.33-3174558-5.patch24.74 KBsvenryen
#2 eu_cookie_compliance-code-improvements-before-releasing-1.33-3174558-2.patch27.05 KBsvenryen
inspections7.zip395.58 KBsvenryen

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-code-improvements-before-releasing-1.33-3174558-2.patch27.05 KB
svenryen’s picture

svenryen commented
Assigned: Unassigned » neslee canil pinto
Status: Active » Needs review
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Needs work

Patch needs a reroll against latest dev.

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 27696  100 27696    0     0  23471      0  0:00:01  0:00:01 --:--:-- 23471
error: patch failed: eu_cookie_compliance.module:858
error: eu_cookie_compliance.module: patch does not apply
error: patch failed: js/eu_cookie_compliance.js:190
error: js/eu_cookie_compliance.js: patch does not apply
svenryen’s picture

svenryen commented
Status: Needs work » Needs review
StatusFileSize
new eu_cookie_compliance-code-improvements-before-releasing-1.33-3174558-5.patch24.74 KB

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Fixed

Committed to dev branch. Thank you.

svenryen’s picture

svenryen commented
Status: Fixed » Needs review
StatusFileSize
new eu_cookie_compliance-code-improvements-before-releasing-1.33-3174558-6.patch25.29 KB

New patch :)

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Needs work

Not able to apply against latest dev

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 25895  100 25895    0     0  18223      0  0:00:01  0:00:01 --:--:-- 18210
error: patch failed: eu_cookie_compliance.admin.categories.inc:6
error: eu_cookie_compliance.admin.categories.inc: patch does not apply
error: patch failed: eu_cookie_compliance.admin.inc:24
error: eu_cookie_compliance.admin.inc: patch does not apply
error: patch failed: eu_cookie_compliance.install:100
error: eu_cookie_compliance.install: patch does not apply
error: patch failed: eu_cookie_compliance.module:90
error: eu_cookie_compliance.module: patch does not apply
error: patch failed: js/eu_cookie_compliance.js:6
error: js/eu_cookie_compliance.js: patch does not apply

  • svenryen committed c970906 on 7.x-1.x 
    Revert "Issue #3174558 by svenryen: [7.x] Code improvements before...

  • svenryen committed 3df34aa on 7.x-1.x 
    Issue #3174558 by svenryen, Neslee Canil Pinto: [7.x] Code improvements...
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Assigned: neslee canil pinto » Unassigned
Status: Needs work » Fixed

  • svenryen committed 062e4fb on 7.x-2.x 
    Merge branch '7.x-1.x' into 7.x-2.x

* 7.x-1.x:
  Issue #3175031 by...
  • svenryen committed 3df34aa on 7.x-2.x
    Issue #3174558 by svenryen, Neslee Canil Pinto: [7.x] Code improvements...
  • Neslee Canil Pinto committed 4529421 on 7.x-2.x authored by svenryen
    Issue #3174558 by svenryen: [7.x] Code improvements before releasing 1....
  • svenryen committed c970906 on 7.x-2.x
    Revert "Issue #3174558 by svenryen: [7.x] Code improvements before...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.