Problem/Motivation

The codebase throws a lot of messages in the PhpStorm inspection tool.

Proposed resolution

We should go through these and improve the quality of the code before releasing 1.10.

A report can be gathered in PhpStorm, and also the output has been attached here for convenient reference.

CommentFileSizeAuthor
#5 eu_cookie_compliance-code-improvements-before-release-of-1.10-3174557-4.patch14.4 KBsvenryen
#2 eu_cookie_compliance-code-improvements-before-release-of-1.10-3174557-2.patch17.65 KBsvenryen
inspections.zip412.69 KBsvenryen

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-code-improvements-before-release-of-1.10-3174557-2.patch17.65 KB
svenryen’s picture

svenryen commented
Assigned: Unassigned » neslee canil pinto
Status: Active » Needs review
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Needs work

Patch needs a reroll against latest dev.

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 18074  100 18074    0     0  19146      0 --:--:-- --:--:-- --:--:-- 19125
error: patch failed: eu_cookie_compliance.install:268
error: eu_cookie_compliance.install: patch does not apply
error: patch failed: eu_cookie_compliance.module:14
error: eu_cookie_compliance.module: patch does not apply
error: patch failed: js/eu_cookie_compliance.js:209
error: js/eu_cookie_compliance.js: patch does not apply
error: patch failed: src/CookieCategoryListBuilder.php:4
error: src/CookieCategoryListBuilder.php: patch does not apply
error: patch failed: src/Form/CookieCategoryForm.php:6
error: src/Form/CookieCategoryForm.php: patch does not apply
error: patch failed: src/Form/EuCookieComplianceConfigForm.php:121
error: src/Form/EuCookieComplianceConfigForm.php: patch does not apply
svenryen’s picture

svenryen commented
Status: Needs work » Needs review
StatusFileSize
new eu_cookie_compliance-code-improvements-before-release-of-1.10-3174557-4.patch14.4 KB

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Assigned: neslee canil pinto » Unassigned
Status: Needs review » Fixed

Committed to dev branch. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.