This bug was originally reported at #3172225: Toolbar menu inaccessible when javascript disabled, and then fixed within the theme. However, this fix should be incorporated into the Toolbar module template.

The issue is that when JS is disabled, the toolbar is not visible due to a lack of a clearfix CSS class within the markup.

According to @alexpott

#2349767: Copy toolbar templates to Classy over zealously removed the clearfix but then #2548027: Follow-up add back aria-label to toolbar tray added some back in but forgot this one. I think we should add the template in Olivero and open an issue to fix this in the toolbar module. And then maybe we can remove the template from any theme where it is not customised.

CommentFileSizeAuthor
#10 3174422-10.patch2.4 KBawset
#7 interdiff_3-7.txt958 byteskomalk
#7 3174422-7.patch1.78 KBkomalk
#3 3174422-3.patch582 bytesmunish.kumar

Comments

mherchel created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Novice, +Bug Smash Initiative

This would make a good novice issue, tagging as such during Bug Smash triage

munish.kumar’s picture

munish.kumar commented
Status: Active » Needs review
StatusFileSize
new 3174422-3.patch582 bytes

Please review

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

We also need to fix stable and stable9 themes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Needs work
komalk’s picture

komalk commented
Assigned: Unassigned » komalk
komalk’s picture

komalk commented
Assigned: komalk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3174422-7.patch1.78 KB
new interdiff_3-7.txt958 bytes

Worked on #4

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

tanubansal’s picture

tanubansal commented

#3 is working fine on 9.1

awset’s picture

awset commented
StatusFileSize
new 3174422-10.patch2.4 KB

When doing testing on #7 above,
I found there is an issue with on branch 9.2.x for below theme:
- Claro.

Added a patch file for addressing those. and tested the patch on below themes
- bartik
- claro
- olivero
- seven
- stable
- stable9

cheers.

asishsajeev’s picture

asishsajeev commented
Assigned: Unassigned » asishsajeev
asishsajeev’s picture

asishsajeev commented
Status: Needs review » Reviewed & tested by the community

#10 Patch applied successfully. Found working on all themes.

asishsajeev’s picture

asishsajeev commented
Assigned: asishsajeev » Unassigned
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Toolbar menu inaccessible when javascript disabled » [backport] Toolbar menu inaccessible when javascript disabled

Committed 11b503b and pushed to 9.2.x. Thanks!

Going to ping @lauriii about backporting this to 9.1.x

  • alexpott committed 11b503b on 9.2.x 
    Issue #3174422 by komalk, munish.kumar, awangsetyawan: Toolbar menu...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: [backport] Toolbar menu inaccessible when javascript disabled » Toolbar menu inaccessible when javascript disabled
Status: Reviewed & tested by the community » Fixed

Discussed with @lauriii and we agreed to leave this to 9.2.x because it is a minor.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.