Closed (fixed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Sep 2020 at 17:10 UTC
Updated:
19 Oct 2020 at 08:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
andypostfixed RFC link and basic patch
Comment #3
andypostComment #4
andypostValid patch
Comment #6
anmolgoyal74 commentedRemoved the test for warning also.
Comment #8
anmolgoyal74 commentedComment #10
andypostI think this checks could be done conditionally,
so for php < 8 the test will remain the same but for 8+ will change expectations
Comment #11
alexpottHere's something that generates a warning for PHP 7 and PHP 8... https://3v4l.org/rQjN0 let's use that.
Comment #13
alexpottComment #14
krzysztof domańskiComment #16
catchCommitted 9557448 and pushed to 9.1.x. Thanks!