Closed (fixed)
Project:
Gin Admin Theme
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
29 Sep 2020 at 11:57 UTC
Updated:
22 Oct 2020 at 06:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
webflo commentedComment #3
anruetherMaybe tasty_backend_gin does something similar? https://www.drupal.org/project/tasty_backend_gin
Comment #4
saschaeggiComment #5
saschaeggi@webflo can you please test the latest dev? as I think this is the same issue as #3175265: Include custom toolbar items in secondary toolbar
Thanks
Comment #6
dieterholvoet commentedI don't think my patch completely covered this issue. There's still the problem that custom toolbar / administration menu items have no icon by default. It would be easier if the only necessary CSS to provide a custom icon would be the mask image.
Comment #7
saschaeggiComment #8
dieterholvoet commentedI replaced some selectors targeting specific icons with more general ones and everything still seems to be working. All you have to do now to add an icon for a new menu link is add a mask image, eg.
There's still the problem that menu links without an icon look bad, but we should probably create a new issue for that.
Comment #9
dieterholvoet commentedCould you share what icon pack you're getting the icons from? Can be useful for people searching for similar looking icons for their custom menu items.
Comment #10
saschaeggiMost of them are custom icons made by myself. But I can recommend this OpenSource library, will blend in nicely: https://feathericons.com/
Comment #11
dieterholvoet commentedGreat, thanks for the tip!
Comment #12
saschaeggiWas fixed along with #3175440: Menu items without links are not themed correctly.
Comment #13
webflo commentedThanks! 👍