Problem/Motivation

We noticed that the color change for the 2nd level menu links doesn't work. I think that's because it gets overridden by the .navbar-nav > .dropdown.active > .dropdown-menu .nav-link selector. I think that color definition in _navbar-second-level-horizontal.scss can be removed.

Steps to reproduce

Set up a menu with the 2nd level displayed horizontally.

Proposed resolution

Either remove the color definition or add the 

@include hover-focus() {
              color: $header-link-hover-color;
            }

definition.

CommentFileSizeAuthor
#4 3173581-2nd-level-menu-links-hover-4.patch689 bytessasanikolic
#3 3173581-2nd-level-menu-links-hover.patch757 bytessasanikolic

Comments

sasanikolic created an issue. See original summary.

sasanikolic’s picture

sasanikolic commented
Issue summary: View changes
sasanikolic’s picture

sasanikolic commented
Status: Active » Needs review
StatusFileSize
new 3173581-2nd-level-menu-links-hover.patch757 bytes

This patch removes the color definition for the 2nd level menu links that are under an active 1st level link. Although now I double-checked, and I see this was explecitly set in dc644b25ebf301caece6f12966891fc1f2ad4f91 commit. Not sure why, as there's no specific comment.
Maybe it'd be better to add a hover effect in this case?

sasanikolic’s picture

sasanikolic commented
StatusFileSize
new 3173581-2nd-level-menu-links-hover-4.patch689 bytes

Here is the patch with the 2nd proposal.

  • pivica committed e8361cd on 8.x-1.x authored by sasanikolic 
    Issue #3173581 by sasanikolic: Second level menu links don't have a...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Thx, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.