Problem/Motivation

Writing good tests is not easy. Writing good tests that work for both Config Filter 1.x 2.x and the core API is even more difficult.
But it doesn't have to be!
We can add a test trait that has the same methods in 1.x and 2.x which allows us to assert what is going to be exported and imported. This way the expectations for 1.x and 2.x can be the same and the test could run also when a module switches to the core api.

Steps to reproduce

tbd

Proposed resolution

Add test trait and example test demonsrating its use

Remaining tasks

implement it
open issues on projects using config filter suggesting its use.

User interface changes

none

API changes

new test traits

Data model changes

none

CommentFileSizeAuthor
#2 3173393-2.x-2.patch6.22 KBbircher

Comments

bircher created an issue. See original summary.

bircher’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new6.22 KB

Attached a proposal, maybe we could add this trait also to core.

  • bircher committed 45c8fbf on 8.x-2.x
    Issue #3173393 by bircher: Add test traits to harmonize tests
    

  • bircher committed 33b4aba on 8.x-1.x
    Issue #3173393 by bircher: Add test traits to harmonize tests, add trick...
  • bircher committed e1c9530 on 8.x-1.x
    Issue #3173393 by bircher: Add test traits to harmonize tests
    
bircher’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.