Problem/Motivation

I'd like to change the wrapper class when a given field on the wrapped entity is empty.

Steps to reproduce

Try setting NULL as the field value on a regular FieldValueVariantCondition, and see that it doesn't match when the field has no value (probably as expected).

Proposed resolution

Create a new variant condition, EmptyFieldVariantCondition

Remaining tasks

Upload patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#7 3172766--empty-field-variant-condition--7.patch5.48 KBe0ipso
#3 3164306-3.patch1.56 KBhawkeye.twolf
#2 3164306-2.patch1.64 KBhawkeye.twolf

Comments

hawkeye.twolf created an issue. See original summary.

hawkeye.twolf’s picture

hawkeye.twolf
they/them or he/him
Primary language English
Location ᏙᎩᏯᏍᏗ Unalatogiyasdi, Tsalaguwetiyi (Cherokee country)
commented
Status: Active » Needs review
StatusFileSize
new 3164306-2.patch1.64 KB
hawkeye.twolf’s picture

hawkeye.twolf
they/them or he/him
Primary language English
Location ᏙᎩᏯᏍᏗ Unalatogiyasdi, Tsalaguwetiyi (Cherokee country)
commented
StatusFileSize
new 3164306-3.patch1.56 KB

Remove copy/paste comment.

hawkeye.twolf’s picture

hawkeye.twolf
they/them or he/him
Primary language English
Location ᏙᎩᏯᏍᏗ Unalatogiyasdi, Tsalaguwetiyi (Cherokee country)
commented
Title: Support wrapper class variants for when a field has no value » Support wrapper class variants for when a field is empty
hawkeye.twolf’s picture

hawkeye.twolf
they/them or he/him
Primary language English
Location ᏙᎩᏯᏍᏗ Unalatogiyasdi, Tsalaguwetiyi (Cherokee country)
commented
Issue summary: View changes
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Thanks for the patch! I will merge this onto 3.x.

However, I think that it would be fair to also have special handling for the case when the FieldValueVariantCondition receives a NULL to check if it's empty. This is in line with the principle of least astonishment, given that this is what you tried first and didn't work.

After the patch there should be 2 ways of using a variant when a field is empty, using the new condition, or passing NULL to FieldValueVariantCondition.

Does that sound fair?

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 3172766--empty-field-variant-condition--7.patch5.48 KB

Patch updated implementing the suggestion in #6.

  • e0ipso committed f051074 on 3.x authored by hawkeye.twolf 
    Issue #3172766 by hawkeye.twolf, e0ipso: Support wrapper class variants...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Thanks for this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.