Problem/Motivation

\Drupal\build_hooks\Controller\FrontendEnvironmentTitleController::frontendDeploymentTitle interacts with the current request and uses explode to get the entity ID.
It should just use the routing system.

Steps to reproduce

Proposed resolution

Add a type-hinted argument for the $frontend_environment to the method and use that instead

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 3172096-11.patch3.27 KBPooja Ganjage
#10 3172096-10.patch1.96 KBPooja Ganjage
#8 interdiff_4-5.txt700 bytessarvjeetsingh
#8 3172096-5.patch1.21 KBsarvjeetsingh
#4 3172096-4.patch1.21 KBPooja Ganjage

Comments

larowlan created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Novice
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +DrupalGov 2020
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3172096-4.patch1.21 KB

Hi,

Creating a patch for this issue.

Please review the patch.

Let me know if any suggestions.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 3172096-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

sarvjeetsingh’s picture

sarvjeetsingh commented
Assigned: Unassigned » sarvjeetsingh
sarvjeetsingh’s picture

sarvjeetsingh commented
Assigned: sarvjeetsingh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3172096-5.patch1.21 KB
new interdiff_4-5.txt700 bytes

Status: Needs review » Needs work

The last submitted patch, 8: 3172096-5.patch, failed testing. View results

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3172096-10.patch1.96 KB
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3172096-11.patch3.27 KB