Problem/Motivation

There are no tests in the module

Steps to reproduce

Proposed resolution

Write some tests

Remaining tasks

User interface changes

API changes

Data model changes

Comments

larowlan created an issue. See original summary.

larowlan’s picture

Assigned: Unassigned » larowlan
larowlan’s picture

Status: Active » Needs review
StatusFileSize
new19.09 KB
larowlan’s picture

StatusFileSize
new20.04 KB
larowlan’s picture

Assigned: larowlan » Unassigned
acbramley’s picture

Status: Needs review » Needs work

A few minor fixes, otherwise looks really good and thorough!

  1. +++ b/tests/src/Functional/UiTest.php
    @@ -0,0 +1,256 @@
    +  public function testBuildHooksUi() {
    

    Missing a doc block here

  2. +++ b/tests/src/Functional/UiTest.php
    @@ -0,0 +1,256 @@
    +   * Assert that anonymous uses can't access privileged pages.
    

    s/uses/users for the 3 assert functions

  3. +++ b/tests/src/Functional/UiTest.php
    @@ -0,0 +1,256 @@
    +  private function assertFrontEndEnvironmentDeploymentFormFunctionality(
    +    FrontendEnvironmentInterface $environment
    +  ) {
    

    Does this need to be split over 3 lines?

larowlan’s picture

Status: Needs work » Needs review
StatusFileSize
new1.97 KB
new20.08 KB

Thanks, here's those changes

acbramley’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

larowlan’s picture

Status: Reviewed & tested by the community » Needs review

Adding review credits

  • larowlan committed c207d8e on 8.x-2.x
    Issue #3171708 by larowlan, acbramley: Add test coverage
    
larowlan’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.