Problem/Motivation

Update .info.yml include "core_version_requirement: ^8 || ^9".
Only local images are allowed.

Only local images are allowed.

CommentFileSizeAuthor
#11 Screenshot 1942-06-31 at 12.13.01 PM.png31.25 KBgauravvvv
#9 Screenshot 1942-06-31 at 11.59.21 AM.png57.35 KBgauravvvv
#8 updated_files-3171220-8.patch2.07 KBmeghasharma
#7 updated_files-3171220-8.patch0 bytesmeghasharma
#5 Screenshot 2020-09-16 at 1.29.35 PM.png273.85 KBsarvjeetsingh
#5 Screenshot 2020-09-16 at 1.27.08 PM.png175.19 KBsarvjeetsingh
#2 3171220-2.patch466 bytessanjayk

Issue fork swiftype-3171220

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    sanjayk created an issue. See original summary.

    sanjayk’s picture

    sanjayk commented
    StatusFileSize
    new 3171220-2.patch466 bytes

    Added core_version_requirement in .info.yml

    sanjayk’s picture

    sanjayk commented
    Status: Active » Needs review
    sarvjeetsingh’s picture

    sarvjeetsingh commented
    Assigned: Unassigned » sarvjeetsingh
    sarvjeetsingh’s picture

    sarvjeetsingh commented
    Issue summary: View changes
    Status: Needs review » Needs work
    StatusFileSize
    new Screenshot 2020-09-16 at 1.27.08 PM.png175.19 KB
    new Screenshot 2020-09-16 at 1.29.35 PM.png273.85 KB

    Hey, @sanjayk, I could not apply the patch because of some errors in the info.yml file.
    I think the 'version' key should be removed from this patch.

    Other than that, I ran drupal-check and I have found some error related to deprecated code.

    meghasharma’s picture

    meghasharma commented
    Assigned: sarvjeetsingh » meghasharma
    meghasharma’s picture

    meghasharma commented
    Assigned: meghasharma » Unassigned
    Status: Needs work » Needs review
    StatusFileSize
    new updated_files-3171220-8.patch0 bytes

    please ignore this patch

    meghasharma’s picture

    meghasharma commented
    StatusFileSize
    new updated_files-3171220-8.patch2.07 KB

    fixed #5 comment errors
    please review the patch

    gauravvvv’s picture

    gauravvvv commented
    StatusFileSize
    new Screenshot 1942-06-31 at 11.59.21 AM.png57.35 KB

    @meghasharma Patch #8 didn't worked for me. Adding a screenshot for ref.

    gauravvvv’s picture

    gauravvvv commented
    Status: Needs review » Needs work
    gauravvvv’s picture

    gauravvvv commented
    StatusFileSize
    new Screenshot 1942-06-31 at 12.13.01 PM.png31.25 KB

    @meghasharma Patch #8 working fine for me. Adding a screenshot for ref. Moving to RTBC

    gauravvvv’s picture

    gauravvvv commented
    Status: Needs work » Reviewed & tested by the community