Problem/Motivation

I am trying to use php 7.4. Everything seems to be working, although there are some (notice) messages:
- Trying to access array offset on value of type bool in at_generate_html_classes()/adaptivetheme_page_alter()/

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 adaptivetheme_php7.4-generate-classes_3171050-4.patch1.86 KBdanchadwick
#3 adaptivetheme_php7.4-generate-classes_3171050.patch1.14 KBdanchadwick

Comments

edvanleeuwen created an issue. See original summary.

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented
Issue summary: View changes
danchadwick’s picture

danchadwick commented
Status: Active » Needs review
StatusFileSize
new adaptivetheme_php7.4-generate-classes_3171050.patch1.14 KB

menu_get_item() can return FALSE. This patch protects against referencing it as if it were an array.

danchadwick’s picture

danchadwick commented
StatusFileSize
new adaptivetheme_php7.4-generate-classes_3171050-4.patch1.86 KB

Found a second call to menu_get_item(), which also needs fixing.

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented

Ok, tested and verified.

Thanks for the patch!

Irbis’s picture

Irbis commented

Patch #4 also works for me:

Environment versions:

Drupal: 7.79
PHP: 7.4.16
Web-server: Apache/2.4.46 (Ubuntu)
DBMS version: MySQL 8.0.23
Theme: Mix and Match 7.x-2.1 based on AdaptiveTheme 7.x-3.4

hey_germano’s picture

hey_germano
she/her
Primary language English
Location Minneapolis, MN, USA
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch! I can confirm this clears up the notices. The logic looks good. Moving to RTBC.

mattbloomfield’s picture

mattbloomfield commented

I've committed this to the 7.x-3.x branch. It should make its way into a release sometime in the near future.

mattbloomfield’s picture

mattbloomfield commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.