Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Achieve better compliance with core eslint standards
Steps to reproduce
N/A
Proposed resolution
Update .csscomb.json according to new structure https://github.com/csscomb/csscomb.js/blob/dev/doc/configuration.md .
Remaining tasks
Apply changes, compile and test.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | vartheme_bs4-update_csscomb-3170255-9.patch | 380 bytes | abu-zakham |
| #2 | vartheme_bs4-update_csscomb-3170255-2.patch | 48.04 KB | josebc |
Comments
Comment #2
josebc commentedComment #3
josebc commentedComment #4
rajab natshahComment #6
rajab natshahCommitted ... Thank you Jose <3
I'm ready and happy to commit any change you like us to have for any standard or ignore files :)
Comment #7
rajab natshahComment #8
rajab natshahComment #9
abu-zakham commentedAnother missing sort-order
Comment #10
rajab natshahThank you Abu Zakham for following up and the patch.
Let's add it for sure.
Let's do this in the new issue.
I like to check with Jose and have him as a reference point to review these standard checking files.
Please, Jose, Razem if you could check on the following issues
Case study and example theme
#3171126: Add yarn script commands for Drupal coding standard and Drupal Practice for Vartheme BS4 and VARTHEME_BS4_SUBTHEME
Case study and example module
#3171132: Add yarn script commands for Drupal coding standard and Drupal Practice for Varbase Media Hero Slider
This could follow in all custom or contrib projects
Let us check with Jose on all checking standards and precise
The current template of files are only a starting point
29 May 2020
#3143759: Add Default CSSLint, ESLint, Stylelint , and Yarn files in Vartheme BS4 and Vartheme Sub-theme
15 Jul 2020
#3159295: Change ( npm install ) to ( yarn install ) in the Script generator for a new Vartheme BS4 sub theme
So we could work on all issues like
#3143270: Fix minor code standard on generated Vartheme BS4 Sub-theme
#3142973: Fix CSSLint errors on generated Vartheme BS4 Sub-theme
Checking standard with stylelint is harder to fix from the old csslint.
My target is to have the gulp compile with 0 error and 0 warnings
Comment #11
rajab natshahFollow up issue #3171951: Add missing sort-order in .csscomb.json