adas-generate needs to be updated for Drush 9 and also to simple_sitemap 8.x-3.x

CommentFileSizeAuthor
#2 remove-adas-generate-drush-command-3169865-2.patch1.22 KBsonfd

Comments

mikran created an issue. See original summary.

sonfd’s picture

sonfd
he/they
Location Portland, ME
commented
Status: Active » Needs review
StatusFileSize
new remove-adas-generate-drush-command-3169865-2.patch1.22 KB

I'm seeing that my sitemaps won't generate correctly via cron if this drush command exists. I am not sure, but I don't think this is needed anymore when using the 3.x branch of simple_sitemap. I'm seeing that my domain variant sitemaps are generated when I use their command, `drush simple-sitemap-generate`, but only if I comment out or remove this file.

Attaching a patch that removes this file altogether. It seems to be a leftover from the original 1.x -> 2.x transition. The command references a service that existed in the 1.x branch, but no longer exists in the 2.x branch.

mikran’s picture

mikran commented
Status: Needs review » Reviewed & tested by the community

Oh I did not even consider that drush simple-sitemap-generate would handle the variants too, that's nice.

aleevas’s picture

aleevas
he/him
Primary language Russian
commented

Thank you @sonfd
Your patch works fine.
That's have to merged to dev branch.

  • hamrant committed 91a5a3b on 8.x-2.x authored by sonfd 
    Issue #3169865 by sonfd, mikran, aleevas, hamrant: Drush command does...
hamrant’s picture

hamrant commented
Status: Reviewed & tested by the community » Fixed

Thanks all, commited to 8.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.