Hi.

I have Node Comments 6.x-1.2-rc1 installed with Views 2.0 RC4 and I'm not seeing the default node comment views - nodecomments and nodecomments_threaded.

My suspicion is that one of the changes from RC3 to RC4 (http://drupal.org/node/315506) made the views disappear.

Any ideas?

Thanks!

Erik.

CommentFileSizeAuthor
#2 nodecomment_viewsrc4.patch15.63 KBrwohleb

Comments

rys322’s picture

rys322 commented

They don't show up for me either. I used to be on Views 2.0 RC3 and upgraded to RC4 to try to fix my problem but it didn't change it. Does anyone have the code for the node_comments view and I can just manually input them?

rwohleb’s picture

rwohleb
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new nodecomment_viewsrc4.patch15.63 KB

The changes in Views RC4 did break the nodecomment module... specifically the changes to views handler and plugin code. I am attaching a patch that fixes nodecomment for RC4. This patch still needs testing.

sirkitree’s picture

sirkitree commented
Status: Needs review » Active

The module has already been patched for this. see #314565: Update D6 branch to work with View2 RC3

sirkitree’s picture

sirkitree commented
Status: Active » Postponed (maintainer needs more info)

try out the new release and let me know if you still do not see these views. i see them on my local installation.

rwohleb’s picture

rwohleb
he/him
Primary language English
commented

Yeah, the latest code seems to work properly with Views RC4. Thanks for pointing it out.

You may with to take a look at "/help/views/api-handlers" on your Drupal install. They are advocating a specific handler naming schema. I came across it earlier.

jo1ene’s picture

jo1ene commented
Title: Default views not showing up in Views 2.0 RC4 » Default views not showing up in Views 2.0 RC5
Version: 6.x-1.2-rc1 » 6.x-1.2-rc2

As the title suggests, I'm using Views RC5 and Nodecomment RC2 and seem to have this issue. Was something else broken?

OT: Also the documentation on this page needs updating for D6:
http://drupal.org/node/234681

rys322’s picture

rys322 commented
Title: Default views not showing up in Views 2.0 RC5 » Default views not showing up in Views 2.0 RC4
Status: Postponed (maintainer needs more info) » Active

switching to node comments RC2 solved my problem, though I am still using views rc 4. Thanks for being on top of this and solving the problems, this really is a great module.

jo1ene’s picture

jo1ene commented
Status: Active » Fixed

In fact, a clean installation shows that Nodecomments RC2 works fine with Views RC4. Upgrading to Views RC5 works too. Previously, I must have had some weird mismatch.

Repoen if another problem is discovered.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.