Problem/Motivation

Sorting the files on dump would make it much easier to visually diff the changes.

Steps to reproduce

n/a

Proposed resolution

Sort the include files and psr loaded classes on dump.

Remaining tasks

Do it

User interface changes

n/a/

API changes

n/a

Data model changes

n/a

Comments

kim.pepper created an issue.

hussainweb’s picture

hussainweb
Primary language English
commented

Apologies for the late response here.

@kim.pepper, can you share more details on how this is useful? Since the generated script is usually not committed, do you see a value on generating a diff?

Unfortunately, it's not simple to do this. The package that we use does not provide such options. It sorts the scripts based on the number of hits. I think there are methods where we get the list and can generate the script but this is a lot of work. We can even create an upstream issue to suggest this feature.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Haven't been using this module for a while now.

I think our deployment process required us to generate it as a build step.

How are you running it in production?

hussainweb’s picture

hussainweb
Primary language English
commented

I had kept it aside for a while and only just got back to this to evaluate how much difference preloading still makes. In any case, I don't see a lot of use cases where we would need to commit the preload script. I guess it only makes sense to commit this file when you have a fairly unchanging site with mostly the same traffic pattern. In that case, the preload script would be valuable to keep around for a long time. In other cases, it makes sense to regenerate the script from fresh usage patterns regularly and definitely after upgrades or adding/removing modules.