CommentFileSizeAuthor
#6 interdiff-3168758-6.txt1017 bytesjigish.addweb
#6 3168758-6.patch8.59 KBjigish.addweb
#5 dev1.dataninja.net_clouds_terraform_workspace.png315.08 KByas
#3 3168758-3.patch7.26 KBjigish.addweb

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Issue summary: View changes
jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3168758-3.patch7.26 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new dev1.dataninja.net_clouds_terraform_workspace.png315.08 KB

@jigishaddweb

Thank for adding the feature. I tested the patch and it looks good to me. I have one thing that I want you to change, could you please make Cloud Service Provider ID as the default sort (ascending)?

workspace.png

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3168758-6.patch8.59 KB
new interdiff-3168758-6.txt1017 bytes
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas

Thank you for testing the patch. I have set default ascending sorting order to Cloud Service Provider ID.

Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. I tested the patch and it looks good to me. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed f3db92c on 8.x-2.x authored by jigish.addweb 
    Issue #3168758 by jigish.addweb, yas: Add test cases for Refresh buttons...

  • yas committed 93f4eda on 3.x authored by jigish.addweb 
    Issue #3168758 by jigish.addweb, yas: Add test cases for Refresh buttons...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 3.0.0-alpha1 » 3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.