Problem/Motivation

Following this issue Loosen required implementation of time service injected to CMs' EntityModerationForm i investigated mistake annotation description for Interface early was Time and recently changed to be TimeInterface in branch 9.1.0 i added some comment on the commit in drupalcode.org repository

Steps to reproduce

Open this link to see wrong annotation

CommentFileSizeAuthor
#12 3167811-12.patch877 bytesalex.mazaltov

Comments

alex.mazaltov created an issue. See original summary.

alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Issue summary: View changes
alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented

Need review by someone who has rights commit to core
Merge request

alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Related issues: +#3167029: Opt-in core issues into the Drupal.org Issue Forks and Merge Requests Beta
alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Assigned: alex.mazaltov » Unassigned
Issue summary: View changes
alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Issue summary: View changes
pameeela’s picture

pameeela commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Bug Smash Initiative

This is just a comment change, marking RTBC as it looks good.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs review

I tried to merge this from gitlab but couldn't - will ping @Mixologic

alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Status: Needs review » Reviewed & tested by the community
alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Assigned: Unassigned » alex.mazaltov
Priority: Major » Normal
Status: Reviewed & tested by the community » Needs work
alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Issue summary: View changes
Related issues: -#3155022: Loosen required implementation of time service injected to CMs' EntityModerationForm, -#3167029: Opt-in core issues into the Drupal.org Issue Forks and Merge Requests Beta
alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Issue tags: -Bug Smash Initiative
StatusFileSize
new 3167811-12.patch877 bytes

Here the patch to fix this small bug i hope somebody can commit it to the core.
I figured out that some existing test failed in Drupal\Tests\ckeditor\FunctionalJavascript\CKEditorIntegrationTest which is not related to this issue.
Could somebody clarify what i have done wrong?

alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Assigned: alex.mazaltov » Unassigned
Status: Needs work » Needs review
alex.mazaltov’s picture

alex.mazaltov
Primary language Ukrainian
commented
Issue tags: +Bug Smash Initiative
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Reviewed & tested by the community

Re #12, It's a known random fail.

As this is non-code one-line change, queueing a testing is even unnecessary :)

It's good to go to me, thanks!

  • catch committed c3cff82 on 9.1.x 
    Issue #3167811 by alex.mazaltov: Adjust annotation declaration of used...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed c3cff82 and pushed to 9.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.