Meeting Agenda

  1. Introductions
  2. Status
  3. Issue updates and discussion
  4. Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every Monday at 2pm GMT (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣  If you’re attending this meeting, please let us know here *and* leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3166968: August 31, 2020 - Meeting Agenda

Kat Shaw Hello
proeung Good Morning/Afternoon!
komal k Hello
hansa11 Hello everyone :wave:
shaal Hello
kiran.kadam911 Hello Everyone!
mherchel here!
brianperry Hey there.
KarinG Hello! :wave:
sd9121 Hello

1️⃣  Overall project status updateOur path to beta is currently headed towards Drupal 9.1. #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

proeung @mherchel and I are looking to submit a new patch to Core for review this week. :fingerscrossed:
mherchel @Kat Shaw , @mgifford (he/him) and I had a call with the National Federation of the Blind last week! We set up a site for them to do testing on, and expect the testing results (and videos) within two weeks
mherchel super excited about that
mherchel Other than that, I haven’t had time to put in much work into the theme last week
proeung @mherchel Correct me if I'm wrong, but I believe we addressed the majority of the feedback that are in this comment (#3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta). We should be ready to resubmit a new patch up to Core soon?
mherchel I think so…
mherchel need to take another look :slightly_smiling_face:
proeung Great! Really excited to get a new patch submitted for Core committer's review.

2️⃣  Individual issue discussion

proeung This thread is the place to bring up specific issues that need some extra discussion.
mherchel We had a number of people test the following issue, but were unable to reproduce. If anyone runs into this, let us know #3168091: Unable to add new sections in Layout Builder
KarinG ds -> are they using display suite as well?
mherchel Potentially.. I’d love to see if that’s an issue. We did override some layout builder templates, but honestly, I think most of it was just markup / class changes
KarinG Yes they are using display suite - "Display Suite classes breaks Layout Builder if Display Suite is not installed" - not sure how that's a theme issue
KarinG I ran into this -> #3166156: Fix for Error: [] operator not supported for strings in olivero_preprocess_form_element_label() - Fix for Error: [] operator not supported for strings in olivero_preprocess_form_element_label() -> turned out to be a smart_date issue. Fixed now, but it's so easy to think it's a theme issue.
mherchel Nice!
mherchel yeah, looking into the layouts/DS issue more… I think we’re only extending CSS. Not even overriding the templates. (edited)

3️⃣  Where can people help this week?

proeung Feel free to add other suggestions here.
mherchel I need more PM type help. Something that took a lot of time was breaking down the core comment review into individual issues and then responding to each of them. I’d love if someone wanted to take on that role.
proeung We have several tickets that need additional work. Please help process some of these issues. https://www.drupal.org/project/issues/olivero?status=13

Participants:

Kat Shaw, proeung, komal k, hansa11, shaal, kiran.kadam911, mherchel, brianperry, KarinG, sd9121

Comments

mtift created an issue. See original summary.

katannshaw’s picture

katannshaw commented

Attending

hansa11’s picture

hansa11 commented

Attending!

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented

Attending

karing’s picture

karing
Location 🇨🇦
commented

Ici!

brianperry’s picture

brianperry
he/him
commented

Attending.

proeung’s picture

proeung
she/her
commented

Attended

sd9121’s picture

sd9121 commented

Attended

komalk’s picture

komalk commented

Attending!

mtift credited mherchel.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Issue summary: View changes
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.