Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
24 Aug 2020 at 05:40 UTC
Updated:
30 Nov 2020 at 14:19 UTC
Jump to comment: Most recent
Comments
Comment #2
arshadkhan35 commentedLooks great, i didn't find any coding standard issue, I am able to call map services after module installation, moving this to rtbc.
Comment #3
avpadernoComment #4
avpadernoI am changing priority as per https://www.drupal.org/node/539608.
Comment #5
matroskeenHere is the result of the manual review:
1. Code looks good and follows Drupal best practices:
- route access is controlled by separate permission;
- configuration form looks good;
- configuration object has schema and default values;
- custom services use dependency injection;
2. I tried some examples from README file and it works as expected;
3.
phpcsreported about some CS issues, so I reported about it in a new task: #3182737: Fix coding standards errors.Overall, it looks good to me.
Some suggestions for maintainer:
1. Close #3170088: Automated Drupal 9 compatibility fixes, because the module is already Drupal 9 compatible;
2. Create a dev release, so we can see the diff between the last stable version and the ongoing development version;
3. Consider using some existing SDK (i.e. https://yidas.github.io/google-maps-services-php) or create your own to delegate some parts of the project.
Thanks!
Comment #6
avpadernoThe master branch isn't used for Drupal.org projects. The other branch needs to be made the default one, and the master one deleted.
Comment #7
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.