Because d7_shortcut has a required dependency on d7_menu_links, it ends up creating a circular dependency if #3051251: Existing menu links show validation issues on migration (and ALL menu links pointing to node translations are invalid) is also applied. (That issue's patch generates derivatives for d7_menu_links, for example d7_menu_links:node:article for all menu links pointing to article nodes.)
Make d7_menu_links an optional instead of a required dependency of d7_shortcut.
As explained in #7, the dependency on the d7_menu_links migration is safe to completely remove.
None.
None.
None.
None.
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | interdiff_7_11.txt | 1.47 KB | anmolgoyal74 |
| #11 | 3165944-11.patch | 2.36 KB | anmolgoyal74 |
| #7 | 3165944-7.patch | 460 bytes | wim leers |
| #2 | 3165944-2.patch | 474 bytes | wim leers |
Comments
Comment #2
wim leersComment #4
tanubansal commentedTested #2 on 9.1, d7_menu_links is an optional now
Comment #5
quietone commentedThis will get more attention in migration system component
Comment #6
wim leers🙏
Comment #7
wim leersIn fact … I don't see why we need this dependency at all.
It was introduced in #2500513: Upgrade path for Shortcut 7.x (back then still
menu_links, #2669978: Migrate D7 Menu Links renamed themenu_linksmigration tod7_menu_links.Because as of #2021779: Decouple shortcuts from menu links, shortcuts are independent of menu links. Yes, during the migration, we need to query the Drupal 7
menu_linkstable, but there's nothing in thed7_menu_linksthat the migration of shortcuts depends on!Comment #8
wim leersUpdating issue title & summary per #7.
Comment #9
wim leersComment #10
quietone commentedThe migration kernel tests for shortcut need to be updated to remove the running of d7_menu_links.yml. That should provide the proof that the dependency is not necessary.
Comment #11
anmolgoyal74 commentedComment #12
quietone commentedThis looks fine.
Comment #13
alexpottCommitted and pushed ca638fa1e9 to 9.2.x and 995eb1c011 to 9.1.x. Thanks!