For 3rd point, We can not change to $this->assertNoErrorMessage(); due to the error message, The module Google Applications is invalid. Please enable the module..
I added same comment as below
// @FIXME: Not refactored due to the error message,
// The module Google Applications is invalid. Please enable the module.
$this->assertSession()->statusCodeEquals(200);
+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/cloud/config/AwsCloudConfigTest.php
@@ -324,4 +337,129 @@ class AwsCloudConfigTest extends CloudConfigTestBase {
+ // @FIXME: Not refactored due to the error message,
+ // The module Google Applications is invalid. Please enable the module.
+ $this->assertSession()->statusCodeEquals(200);
The comment is good. So can we use $this->assertWarningMessage() here? We can change the comment as follows:
// @FIXME: We don't use assertNoErrorMessage(), since it displays
// "The module Google Applications is invalid. Please enable the module."
Comments
Comment #2
jigish.addweb commentedComment #3
jigish.addweb commentedComment #4
yasCan we use an
array_randfunction here? (Please searcharray_rand($regions)in the enter source code as a reference.)Change to
$add[$i]['regions[]'][]Change to
$this->assertNoErrorMessage();Comment #5
jigish.addweb commentedComment #6
jigish.addweb commented@yas Thank you for reviewing the patch.
For 3rd point, We can not change to
$this->assertNoErrorMessage();due to the error message,The module Google Applications is invalid. Please enable the module..I added same comment as below
Please review the updated patch.
Thanks
Comment #7
yas@jigishaddweb
Thank you for the update.
The comment is good. So can we use
$this->assertWarningMessage()here? We can change the comment as follows:Comment #8
jigish.addweb commentedComment #9
jigish.addweb commentedComment #10
yas@jigishaddweb
Thank you for adding the test case. It looks good to me. I'll merge the patch to
8.x-1.x,8.x-2.xand3.xand close this issue asFixed.Comment #14
yas