Closed (fixed)
Project:
Olivero
Version:
8.x-1.x-dev
Component:
Meetings
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
17 Aug 2020 at 13:44 UTC
Updated:
22 Sep 2020 at 14:14 UTC
Jump to comment: Most recent
Time: 2pm UTC (10am Eastern)
Meeting Location: #d9-theme channel on drupal.slack.com
| mtift (he/him) | Let's use this issue to discuss the overall status of the initiative in broad terms, and we'll save specific issue discussions for later threads. |
| mherchel | Overall… plugging away. Submitted a new core patch a bit ago, and had a review about a week ago. I spent a lot of time going through and responding and breaking out issues |
| mherchel | some of those issues are already resolved… some have work to be done |
| mherchel | Still a lot of PM work for me to do this week |
| Kat Shaw | Working on setting up infrastructure for NFB testing of Olivero. |
| mtift (he/him) | This thread is the place to bring up specific issues that need some extra discussion |
| mherchel | I need help testing this #3165452: Override Drupal.theme.message to to make sure JS messages get rendered correctly. Evidently there’s a page in https://github.com/zolhorvath/cd_tools that can help, but I’m not too familiar w it. When I installed cd_tools it blew up my install (haven’t had time to troubleshoot that yet) |
| mherchel | I’m also thankful for the work in #3135511: Create basic test coverage for Olivero theme. Honestly, I don’t know :poop: about how Druupal does testing. I want to have a discussion on this at some point (@brianperry?) to see what other themes do and how it works |
| mherchel | and then I started work on #3153260: Standardize Olivero's focus states across all non-form controls over a week ago. Still waiting for accessibility team to give a quick review. Honestly, I need to go in and re-roll my work |
| brianperry | Happy to talk about the testing @mherchel I'm learning as well. From what I can tell, other themes don't really do much. We might actually have more test coverage with this patch :slightly_smiling_face: |
| mherchel | interesting. you got time later this week for a 30 min call? |
| proeung | #3165448: Patch script generates *.pcss.css fies within the dist directory has been merged. Please see this slack message for more context. https://drupal.slack.com/archives/CJT807H7T/p1597931243001600 |
| brianperry | @mherchel I should be able to find time for a call later this week. |
| mtift (he/him) | Help with testing #3165452: Override Drupal.theme.message to to make sure JS messages get rendered correctly is one place. |
| mtift (he/him) | Feel free to add other suggestions here |
Participants:
mtift (he/him), mherchel, Kat Shaw, brianperry, proeung
Comments
Comment #2
katannshaw commentedAttending
Comment #3
shaalAttending
Comment #4
indrajithkb commentedAttending
Comment #5
hansa11 commentedAttending :)
Comment #6
sd9121 commentedAttending :)
Comment #7
WebbehAttended.
Comment #8
brianperryAttended and provided updates on https://www.drupal.org/project/olivero/issues/3135511#comment-13798593
Comment #9
ruchi-94 commentedAttended!
Comment #10
komalk commentedAttending.
Comment #11
mtiftComment #12
mtiftComment #14
mtift