Problem/Motivation

The data in the Value column is double escaped.

Steps to reproduce

  1. Configure site name: Salt & vinegar
  2. Visit /admin/reports/config-inspector/system.site/list and observe the 'Value' column is double escaped: Salt & vinegar

Proposed resolution

Remove the Html::escape() call from \Drupal\config_inspector\Controller\ConfigInspectorController::formatValue() and rely on Twig auto-escaping.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The data in the Value column is no longer double escaped.

API changes

None.

CommentFileSizeAuthor
#2 3165248-2.patch771 bytesidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 3165248-2.patch771 bytes

Attached patch removes the Html::escape() call from \Drupal\config_inspector\Controller\ConfigInspectorController::formatValue() and so it relies on Twig auto-escaping only.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Reviewed & tested by the community

  • vuil committed 151873b on 8.x-1.x authored by idebr 
    Issue #3165248 by idebr, vuil: Config list double escapes 'Value' column
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.