On the Chameleon theme delivered with drupal, the OpenID icon appears right under "Log in using OpenID". Example is attached.

I would have selected the Chameleon theme in the dropdown, but it's not present.

Comments

robloach’s picture

Version: 6.4 » 7.x-dev
Component: other » openid.module

I've seen this happen everywhere.

aren cambre’s picture

Should this possibly minor bug be fixed in 6?

jrabeemer’s picture

CSS bug confirmed in FF3, IE6/7, Safari3, Opera 9.6.

We need a CSS ninja to come in and fix...

jrabeemer’s picture

Status: Active » Needs work
StatusFileSize
new8.02 KB
new545 bytes

Moved over the padding. A caveat however, IE6/7 shows the standard bullet from ul.leaf. It's annoying somewhat.

jrabeemer’s picture

I tested the patch in IE8 beta 1. The stray ul.leaf bullet isn't there, so I'm satisfied that the CSS is correct and IE6/7 just has priority bugs in regards to background images.

jrabeemer’s picture

Title: OpenID icon misplaced on Chameleon theme » OpenID icon misplaced under login text
Issue tags: +CSS, +OpenID

Retitling... occurs in all themes.

jrabeemer’s picture

Status: Needs work » Needs review

Moving to review to get more eye balls.

dries’s picture

Does that fix the problem at http://mollom.com/user/login (for example)?

jrabeemer’s picture

StatusFileSize
new186.63 KB
new297.86 KB

It appears so. I loaded up Mollom and applied the patch through Firebug. It looks good too.

In IE7, it also shifts left too. I see a 3px shift down but I guess that's specific to Mollom CSS.

jrabeemer’s picture

StatusFileSize
new1014 bytes
jrabeemer’s picture

This removes the spacing around the image and removes the bullets in IE6/7. I think it'll fix it too on Mollom.

One observation: I think D7's Garland theme was changed awhile back that caused the white circle bullets in the login form to change to black solid bullets in non-IE browsers. Anybody can confirm that? If true, that needs a separate bug report.

EDIT:
Found it. #309784: Unordered lists override numbered lists

-repost-
Damnit! Why did the above post come out blank on submit? ^-- This is what I wrote.

jrabeemer’s picture

#2, yes, it affects D6 and should probably be patched there as well.

Jeff Burnz’s picture

Part of the problem is that neither of the item-list UL's have a class set on them making it difficult to theme the OpenID UL separately. Compounding the problem is the text-align center on #user-login-form.

While the above patch at least fixes the core issue by moving the icon to the left, it does not look that good since the alignment of the text is still wrong.

What I am going to propose is a seperate issue but I'd though I bring it up here anyway as its part of my overall idea:

1) remove text-align center on #user-login-form (why are we doing this anyway?)
2) set a class on the Openid UL
3) theme it so it looks great - just a matter of margins and padding.

This will ultimately give designers more control over theming the user login block, and at least the defualt stying will look right.

Thoughts?

Jeff Burnz’s picture

StatusFileSize
new1.41 KB

I've come up with an alternative approach that both shows the icon correctly and the position of the text.

This patch moves the background image from the <li> to the <a> and sets a few sane defaults for ul for both #user-login-form and #user-login.

Garland will require a tweak.

Status: Needs review » Needs work

The last submitted patch failed testing.

Jeff Burnz’s picture

StatusFileSize
new1.44 KB

Wrong path, trying again.

Jeff Burnz’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

Jeff Burnz’s picture

Status: Needs work » Needs review
StatusFileSize
new1.46 KB

OK, try one more time and see if this flys, otherwise I need someone to take a look and see what I am doing wrong here.

I assume there was a tab and not 2 spaces.

Arrr, fm, ignore the name of this patch... :/

netsensei’s picture

Tested the patch in #19 with Stark theme in Safari 3.2, IE6, IE7 and Firefox 3.07. The original issue is fixed in all cases: the image doesn't shift under the text.

Needs testing in IE8? Otherwise I would RTBC.

Jeff Burnz’s picture

Tested also on Stark in IE8 (latest), Chrome and Opera 9.62 - fixed in all instances.

jody lynn’s picture

Status: Needs review » Reviewed & tested by the community
dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

jody lynn’s picture

Version: 7.x-dev » 6.x-dev
Status: Fixed » Patch (to be ported)

This fix should be backported.

Jeff Burnz’s picture

Yes, the CSS is the same from what I recall, until such time that it is backported you can do this - http://adaptivethemes.com/fix-your-openid-login-icon

Jeff Burnz’s picture

Status: Patch (to be ported) » Fixed

This was committed to drupal 6.11.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

alexanderpas’s picture

Issue tags: -OpenID

Do NOT use tags for duplicating the "Assigned" or "Component" fields.