Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
openid.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Oct 2008 at 02:48 UTC
Updated:
17 Nov 2009 at 05:54 UTC
Jump to comment: Most recent file
Comments
Comment #1
robloachI've seen this happen everywhere.
Comment #2
aren cambre commentedShould this possibly minor bug be fixed in 6?
Comment #3
jrabeemer commentedCSS bug confirmed in FF3, IE6/7, Safari3, Opera 9.6.
We need a CSS ninja to come in and fix...
Comment #4
jrabeemer commentedMoved over the padding. A caveat however, IE6/7 shows the standard bullet from ul.leaf. It's annoying somewhat.
Comment #5
jrabeemer commentedI tested the patch in IE8 beta 1. The stray ul.leaf bullet isn't there, so I'm satisfied that the CSS is correct and IE6/7 just has priority bugs in regards to background images.
Comment #6
jrabeemer commentedRetitling... occurs in all themes.
Comment #7
jrabeemer commentedMoving to review to get more eye balls.
Comment #8
dries commentedDoes that fix the problem at http://mollom.com/user/login (for example)?
Comment #9
jrabeemer commentedIt appears so. I loaded up Mollom and applied the patch through Firebug. It looks good too.
In IE7, it also shifts left too. I see a 3px shift down but I guess that's specific to Mollom CSS.
Comment #10
jrabeemer commentedComment #11
jrabeemer commentedThis removes the spacing around the image and removes the bullets in IE6/7. I think it'll fix it too on Mollom.
One observation: I think D7's Garland theme was changed awhile back that caused the white circle bullets in the login form to change to black solid bullets in non-IE browsers. Anybody can confirm that? If true, that needs a separate bug report.
EDIT:
Found it. #309784: Unordered lists override numbered lists
-repost-
Damnit! Why did the above post come out blank on submit? ^-- This is what I wrote.
Comment #12
jrabeemer commented#2, yes, it affects D6 and should probably be patched there as well.
Comment #13
Jeff Burnz commentedPart of the problem is that neither of the item-list UL's have a class set on them making it difficult to theme the OpenID UL separately. Compounding the problem is the text-align center on #user-login-form.
While the above patch at least fixes the core issue by moving the icon to the left, it does not look that good since the alignment of the text is still wrong.
What I am going to propose is a seperate issue but I'd though I bring it up here anyway as its part of my overall idea:
1) remove text-align center on #user-login-form (why are we doing this anyway?)
2) set a class on the Openid UL
3) theme it so it looks great - just a matter of margins and padding.
This will ultimately give designers more control over theming the user login block, and at least the defualt stying will look right.
Thoughts?
Comment #14
Jeff Burnz commentedI've come up with an alternative approach that both shows the icon correctly and the position of the text.
This patch moves the background image from the
<li>to the<a>and sets a few sane defaults for ul for both #user-login-form and #user-login.Garland will require a tweak.
Comment #16
Jeff Burnz commentedWrong path, trying again.
Comment #17
Jeff Burnz commentedComment #19
Jeff Burnz commentedOK, try one more time and see if this flys, otherwise I need someone to take a look and see what I am doing wrong here.
I assume there was a tab and not 2 spaces.
Arrr, fm, ignore the name of this patch... :/
Comment #20
netsensei commentedTested the patch in #19 with Stark theme in Safari 3.2, IE6, IE7 and Firefox 3.07. The original issue is fixed in all cases: the image doesn't shift under the text.
Needs testing in IE8? Otherwise I would RTBC.
Comment #21
Jeff Burnz commentedTested also on Stark in IE8 (latest), Chrome and Opera 9.62 - fixed in all instances.
Comment #22
jody lynnComment #23
dries commentedCommitted to CVS HEAD. Thanks!
Comment #24
jody lynnThis fix should be backported.
Comment #25
Jeff Burnz commentedYes, the CSS is the same from what I recall, until such time that it is backported you can do this - http://adaptivethemes.com/fix-your-openid-login-icon
Comment #26
Jeff Burnz commentedThis was committed to drupal 6.11.
Comment #28
alexanderpas commentedDo NOT use tags for duplicating the "Assigned" or "Component" fields.