Fix the test failures for PHP 7.3/7.4
https://www.drupal.org/pift-ci-job/1727787
https://www.drupal.org/pift-ci-job/1727786
Examples of ones that are not part of the Date module fixes referenced in comment #1 #3164491-1: PHP 7.4: test failures
exception: [Notice] Line 617 of modules/field/field.crud.inc:
Trying to access array offset on value of type nullexception: [Notice] Line 617 of modules/field/field.crud.inc:
Trying to access array offset on value of type null
file_feeds_processor_targets
file_feeds_processor_targets
✗
list_feeds_processor_targets
exception: [Notice] Line 17 of sites/all/modules/feeds/mappers/list.inc:
Trying to access array offset on value of type nullexception: [Notice] Line 17 of sites/all/modules/feeds/mappers/list.inc:
Trying to access array offset on value of type null
✗
number_feeds_processor_targets
exception: [Notice] Line 22 of sites/all/modules/feeds/mappers/number.inc:
Trying to access array offset on value of type nullexception: [Notice] Line 22 of sites/all/modules/feeds/mappers/number.inc:
Trying to access array offset on value of type null
✗
taxonomy_feeds_processor_targets
exception: [Notice] Line 65 of sites/all/modules/feeds/mappers/taxonomy.inc:
Trying to access array offset on value of type nullexception: [Notice] Line 65 of sites/all/modules/feeds/mappers/taxonomy.inc:
Trying to access array offset on value of type null
✗
text_feeds_processor_targets
exception: [Notice] Line 22 of sites/all/modules/feeds/mappers/text.inc:
Trying to access array offset on value of type nullexception: [Notice] Line 22 of sites/all/modules/feeds/mappers/text.inc:
Trying to access array offset on value of type null
phpcs -p --standard=PHPCompatibility --extensions=php,module,inc,install,test,profile,theme .
FILE: feeds.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1376 | WARNING | Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$data" was used, and possibly changed (by reference), on line
| | 1375.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3164491-9-php73-test-failures.patch | 1.38 KB | joelpittet |
Comments
Comment #2
megachrizI think that the test failures are caused by the Date module. So I guess we would need to wait until 7.x-2.11 of that module gets released. See #2867810: Plan for Date 7.x-2.11 release.
Comment #3
joelpittetSome of them are from here and some from the date module. Sorry I should have made note of that in the issue summary, we won't get them all here.
Comment #4
joelpittetComment #5
joelpittetComment #6
joelpittetComment #7
joelpittetComment #8
joelpittetComment #9
joelpittetHere's the tests that I could try and fix outside of date.
Comment #11
joelpittetAll the remaining tests failures are due to SimplePie or date module integration tests.
Comment #12
joelpittetUnfortunate I've committed this but the title really fixed PHP 7.4 issues, the 7.3 are all date integration issues.