Fix the test failures for PHP 7.3/7.4

https://www.drupal.org/pift-ci-job/1727787
https://www.drupal.org/pift-ci-job/1727786

Examples of ones that are not part of the Date module fixes referenced in comment #1 #3164491-1: PHP 7.4: test failures

exception: [Notice] Line 617 of modules/field/field.crud.inc:
Trying to access array offset on value of type null

exception: [Notice] Line 617 of modules/field/field.crud.inc:
Trying to access array offset on value of type null
file_feeds_processor_targets
file_feeds_processor_targets
✗
list_feeds_processor_targets
exception: [Notice] Line 17 of sites/all/modules/feeds/mappers/list.inc:
Trying to access array offset on value of type null

exception: [Notice] Line 17 of sites/all/modules/feeds/mappers/list.inc:
Trying to access array offset on value of type null
✗
number_feeds_processor_targets
exception: [Notice] Line 22 of sites/all/modules/feeds/mappers/number.inc:
Trying to access array offset on value of type null

exception: [Notice] Line 22 of sites/all/modules/feeds/mappers/number.inc:
Trying to access array offset on value of type null
✗
taxonomy_feeds_processor_targets
exception: [Notice] Line 65 of sites/all/modules/feeds/mappers/taxonomy.inc:
Trying to access array offset on value of type null

exception: [Notice] Line 65 of sites/all/modules/feeds/mappers/taxonomy.inc:
Trying to access array offset on value of type null
✗
text_feeds_processor_targets
exception: [Notice] Line 22 of sites/all/modules/feeds/mappers/text.inc:
Trying to access array offset on value of type null

exception: [Notice] Line 22 of sites/all/modules/feeds/mappers/text.inc:
Trying to access array offset on value of type null

phpcs -p --standard=PHPCompatibility --extensions=php,module,inc,install,test,profile,theme .

FILE: feeds.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1376 | WARNING | Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$data" was used, and possibly changed (by reference), on line
      |         | 1375.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
CommentFileSizeAuthor
#9 3164491-9-php73-test-failures.patch1.38 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

megachriz’s picture

Status: Active » Postponed

I think that the test failures are caused by the Date module. So I guess we would need to wait until 7.x-2.11 of that module gets released. See #2867810: Plan for Date 7.x-2.11 release.

joelpittet’s picture

Status: Postponed » Active

Some of them are from here and some from the date module. Sorry I should have made note of that in the issue summary, we won't get them all here.

joelpittet’s picture

Issue summary: View changes
joelpittet’s picture

Issue tags: +PHP 7.4
joelpittet’s picture

Issue summary: View changes
joelpittet’s picture

Issue summary: View changes
joelpittet’s picture

joelpittet’s picture

Status: Active » Needs review
StatusFileSize
new1.38 KB

Here's the tests that I could try and fix outside of date.

  • joelpittet committed 5addb81 on 7.x-2.x
    Issue #3164491 by joelpittet: PHP 7.3: test failures
    
joelpittet’s picture

Status: Needs review » Fixed

All the remaining tests failures are due to SimplePie or date module integration tests.

joelpittet’s picture

Title: PHP 7.3: test failures » PHP 7.4: test failures

Unfortunate I've committed this but the title really fixed PHP 7.4 issues, the 7.3 are all date integration issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.