Delete an article that were already removed in Apple News admin fails because it can't find the content in Apple News, when this happens the module should keep with the process and remove the reference kept in Drupal so we can republish is need it.

CommentFileSizeAuthor
#2 applenews-3163593-fix delete of Apple News articles.patch2.52 KBjuanl

Issue fork applenews-3163593

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

juanl created an issue. See original summary.

juanl’s picture

juanl commented
Status: Active » Needs review
StatusFileSize
new applenews-3163593-fix delete of Apple News articles.patch2.52 KB

I created this patch to fix the issue.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: juanl » Unassigned
Issue tags: +Needs tests
socialnicheguru’s picture

socialnicheguru commented
Status: Needs review » Needs work

does not apply to latest dev:
Gathering patches for dependencies. This might take a minute.
- Installing drupal/applenews (dev-1.x 5f3a85c): Cloning 5f3a85c612 from cache
- Applying patches for drupal/applenews
https://www.drupal.org/files/issues/2020-08-05/applenews-3163593-fix%20d... (Fix delete of Apple News articles)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-08-05/applenews-3163593-fix%20d...

m4olivei opened merge request !12

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: Unassigned » m4olivei

Hi @SocialNicheGuru. I just opened a MR with the patch applied, adjusted slightly and a test written. It should apply against the latest 8.x-1.x-dev.

Let me know if it works for you.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented

I also noticed that there is another scenario that will fail in the same way as reported where the Apple News article entity is not deleted even though the article was deleted upstream. When you uncheck the "Publish to Apple News" checkbox this can happen. I've added a test to show that failure. Expecting the recent commit to fail on that. Fix coming.

  • m4olivei committed 3e1d5db on 8.x-1.x 
    Issue #3163593 by m4olivei, juanl: Fix delete of Apple News articles
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: m4olivei » Unassigned
Status: Needs work » Fixed

Merged to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.