CommentFileSizeAuthor
#6 interdiff.patch3.68 KByonas.legesse
#6 Add_install_file_describing_the_schema_of_the_module-3163484-6.diff2.92 KByonas.legesse
#3 search_log remove.png14.95 KByonas.legesse
#3 search_log install.png19.42 KByonas.legesse
#3 Add_install_file_describing_the_schema_of_the_module-3163484-3.patch2.97 KByonas.legesse

Comments

yonas.legesse created an issue. See original summary.

yonas.legesse’s picture

yonas.legesse commented
Issue summary: View changes
yonas.legesse’s picture

yonas.legesse commented
Status: Active » Needs review
StatusFileSize
new Add_install_file_describing_the_schema_of_the_module-3163484-3.patch2.97 KB
new search_log install.png19.42 KB
new search_log remove.png14.95 KB

For the purpose of testing the functionality of the install file, i set up a fresh instance of Drupal 8.8.7. I've followed the following steps to confirm the error-free functionality:

  1. Created sample .module and .info.yml files to carry out install/uninstall operations
  2. Installed the module and checked for the process along with the final status message
  3. Uninstalled the module and checked for the removal of search_log table from the database
  4. Confirmed the display of the module removal status message

Here are the screenshots of the install/uninstall routines:
Module installation:

Module removal:

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Needs work

@yonas.legesse Can you replace the usage of deprecated functions and long array syntax in the patch.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented

@yonas.legesse Please use short hand notation for array. Quotaed some as follows

  1. +++ b/search_log.install
@@ -0,0 +1,100 @@
+  $schema['search_log'] = array(

    User array shorthands. 

  2. +++ b/search_log.install
@@ -0,0 +1,100 @@
+        'fields' => array(
+          'qid' => array(

    User array shorthands.

yonas.legesse’s picture

yonas.legesse commented
Status: Needs work » Needs review
StatusFileSize
new Add_install_file_describing_the_schema_of_the_module-3163484-6.diff2.92 KB
new interdiff.patch3.68 KB

Removed deprecated codes and implemented short hand array notation.

  • yonas.legesse authored dab5969 on 8.x-1.x 
    Issue #3163484 by yonas.legesse: Add install file describing the schema...
gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: yonas.legesse » Unassigned
Status: Needs review » Fixed

Thanks for working on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.