Closed (fixed)
Project:
Cloud
Version:
3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
5 Aug 2020 at 06:05 UTC
Updated:
25 Aug 2020 at 22:49 UTC
Jump to comment: Most recent, Most recent file
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 3163418-13-hotfix.patch | 410 bytes | yas |
| #6 | 3163418-6.patch | 2.48 KB | yas |
Comments
Comment #2
yasComment #3
yasComment #4
baldwinlouie commented@yas, the changes look good. I was able to verify that
maclof/kubernetes/clientwas picked up!FYI, I *think* I run into the same problem as Drupal CI/CD. For example, I wanted to use your latest composer.json changes in
Cloud Orchestrator. The best I can do is apply your patch here. However, the patch is applied after composer install is ran. Thus the changes are never picked up.My work around was to run a local repository of the cloud module by adding changing the
"name": "drupal_local/local_cloud",incloud'scomposer.json. I can then apply this patch to it.Then in my
Cloud Orchestrator'scomposer.json, instead of requiringdrupal/cloud, I requiredrupal_local/local_cloud, which contains the patched composer.json. I also added alocal repositoryby addingOnly then was I able to build Cloud Orchestrator and have it pick up your patched change.
I do have the following comment.
Do we want to tie it to a branch/tag or move this to "require-dev"?
The reason is that I can foresee conflicts in the future if I ever want to tie "Cloud Orchestrator" to a specific version of bootstrap_Cloud
Comment #5
baldwinlouie commentedTrying a test patch. NOT TO BE checked in yet.
Comment #6
yas@baldwinlouie
Thank you for your comment and test. I updated the patch; so could you please review it?
Comment #7
baldwinlouie commented@yas, thank you for the updated patch. This looks good!
Comment #8
yas@baldwinlouie
Thank you for your review. Let's try to merge the patch to
8.x-1.x,8.x-2.xand3.x!Comment #12
yasComment #13
yasFixing a bug:
Comment #17
yas