Support Geocoder module 3.x in composer.json

@masami

Let me test this patch.

@masami

Let me try this one.

Just a test patch for CI/CD.

@yas I looked at the Test results from the patch in #7. It seems like CI/CD will automatically pick up the Geocoder composer.json requirements.

Will this work? or do we need to add extra requirements to cloud module's composer.json?

@baldwinlouie

Thank you for taking care of this issue. Yes, it looks we need the additional library at Geocoder Provider to use the latest version of Geocoder module (3.7).

We can find the following library to add in the patch at #4.

+++ b/composer.json
@@ -5,6 +5,7 @@
     "aws/aws-sdk-php": "3.*.*@dev",
     "google/apiclient": "^2.4",
     "drupal/geocoder": "^3.1",
+    "geocoder-php/nominatim-provider": "^5.2",

Please compare #5 and #6

It looks it works if we don't touch anything about composer.json according to #8?

@yas, trying geocoder-php/nominatim-provide:5.0 because that is what is in https://git.drupalcode.org/project/geocoder/-/blob/8.x-3.7/composer.json

attempting the patch again.

try again.

switching the order and trying again :)

Again.

Once more.

Trying to keep the fixed version for drupal/geocoder:3.1.

Just curious if this will pass if I just add something other than the require section

@baldwinlouie

Thank you for your attempts. It helps us to figure out the issue :)

@masami

Could you please update from "drupal/geocoder": "^3.1", to "drupal/geocoder": "^3.7", in patch #4?

@masami

Thank you for updating the patch. Could you please move cloud_initialize_geocoder to CloudService::initGeocoder()?

@masami and @yas, Thank you for the patch. It looks good to me.

@baldwinlouie

Thank you for your review. Let's wait just for a while for #3158445. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

@masami
@baldwinlouie

As we discussed, I'll merge the patch.