Maybe I'm missing something, but I don't see why \Drupal\simple_sitemap\Form\FormHelper::processForm() needs to continue if no entity was found.

\Drupal\simple_sitemap\Form\FormHelper::negotiateSettings() does a lot of quite extensive processing, like a config entity query, but the supports call will then just check if NULL is an enabled entity type.

CommentFileSizeAuthor
#2 simple_sitemap-3162869-2.patch512 bytesberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new simple_sitemap-3162869-2.patch512 bytes

  • acdbedd committed on 8.x-3.x 
    Issue #3162869 by Berdir, gbyte: Skip redundant processing of forms
gbyte’s picture

gbyte
Location Berlin
commented
Title: Don't attempt to process forms if no entity can be found » Skip redundant processing of forms
Status: Needs review » Fixed

Thanks, as always a good find (how did you notice?). I altered your logic to still use supports(), but skipping the redundant code.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.