Problem/Motivation

userprotect_user_access() is quite expensive and there is afaik nothing in the module that would limit view access in any way, so lets add an early return to avoid the config entity query lookup for every user.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 userprotect-view-acces-3162846-2.patch632 bytesberdir

Comments

Berdir created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new userprotect-view-acces-3162846-2.patch632 bytes

  • MegaChriz committed bc6fb02 on 8.x-1.x authored by Berdir 
    Issue #3162846 by Berdir, MegaChriz: Avoid config entity query for view...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Thanks for the patch! I added a comment to the code of why we are returning early and committed that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.