Now when not choosing the default option for the consent, you can't choose not to show the more info button. It WILL show up. And the value of the field is required, so you can't disable it. IMO choosing to show or hide that button should always be there and be followed. There is a text field where the user can enter all the necessary data, so having a button below that doesn't make sense then.
Use the patch from #3134169 and save the settings form.
Make sure the show more info button checkbox isn't hidden on non-default consent options so that value can be followed.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3162369_2_dont_make_more_info_required.patch | 1.74 KB | daften |
Comments
Comment #2
daften commentedAdded a patch
Comment #3
svenryen commentedI don't think we will spend time on this. It breaks functionality already delivered, and will likely cause regressions for many of the 1000s of sites that use the module.
I understand that you disagree, but we can't change this.
Comment #4
nick_vhLet's rethink this. It seems a more appropriate way to solve this is by means of an option. It would probably be good to default to the current behavior, but by means of an option of perhaps hiding the show more info, this can be solved in a backwards compatible manner.
Let's rework this patch to make it an option is my suggestion. What do you both think?
Comment #5
daften commentedI agree with both, just removing it was not the best suggestion on my part. Keeping it backwards compatible, but having the option to remove it, seems like the way to go. It avoids custom patches for people and makes less assumptions than is the case now :)
Comment #6
svenryen commentedSure, reworking this patch to make it an option seems like the best solution.
Comment #7
grayle commentedI'm not sure this patch needs reworking? For existing sites, the stored values will remain, so if they relied on the form automatically setting that checkbox to true in the submit if they picked a non-default method, it's already done that. And for new sites, they can simply check the checkbox themselves.
Comment #9
svenryen commentedAccepted and committed