Option to set FROM email [#3162325]

Hello and thank you for this module.
It is easy to use and works well.

I have just encountered a use-case where we want the "From" email to be different from the default/site email.
However the "From" email-address is currently not configurable.

It would be nice if this could be added to this module.

Comment	File	Size	Author
#6	3162325-6-set-from-email.patch	3.91 KB	ankitjhakal
#3	3162325-3-set-from-email.patch	3.86 KB	digdanlow

Issue fork content_moderation_notifications-3162325

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3162325-option-to-set

compare

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

30 July 2020 at 03:25

RdeBoer created an issue. See original summary.

Comment #2

rdeboer

Melbourne

commented 30 July 2020 at 03:26

Issue summary:

View changes

Comment #3

digdanlow commented 30 July 2020 at 14:25

Status	File	Size
new	3162325-3-set-from-email.patch	3.86 KB

Hello! Please try the attached patch. As the schema was changed, it will have to be updated. This can be done using the devel_entity_updates module. If that doesn't work for you, a hook update should be implemented to programmatically update it.

Comment #4

rdeboer

Melbourne

commented 30 July 2020 at 23:16

Wow @digdanlow, that was quick.
Awesome.
Thank you so much. Will try it out.

Comment #5

rdeboer

Melbourne

commented 1 August 2020 at 03:16

I believe this works.
On my system I use an external SMTP server which seems to override the "from" email -- but that's not the fault of this patch.
Thanks for the quick work!

PS:
The devel_entity_updates module... After installing the module and running

drush cr
drush entup

reported:

No entity schema updates required

So instead, as we're still in development for this project, I disabled and re-aneabled the content_moderation_notifications module for the same effect.