Problem/Motivation

When content_access is installed as part of a Drupal profile, content_access_install ignores whatever values are set in content_access.settings.
It should instead try to merge the values if they exist.

Steps to reproduce

Add an existing content_access config with custom settings to a distribution, and attempt a clean install. Those settings will be lost.

Proposed resolution

Add logic for checking if the values exist before trying to add them.

Remaining tasks

Submit patch

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#2 3161886-profile-support.patch2.43 KBcodebymikey

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

codebymikey commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3161886-profile-support.patch2.43 KB
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented

Code looks good, but I don't use profiles myself – so I am not the best person to test and review this.

Will be committed as soon as anyone that is familiar with how profiles work in the Drupal ecosystem has reviewed it and confirms that it works.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Category: Task » Feature request

All feature requests go into the most recent branch.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs work » Needs review

The community needs to review this.

If we add this feature, it would also be nice to have a few paragraphs describing how to use this feature in the module documentation.

steven jones’s picture

steven jones commented

Related to #2960330: role/gid mapping refresh when gid missing (related to configuration synchronisation of content_access.settings and grey listing of roles with config_split) and could potentially be solved in the same way. Maybe this doesn't need to be config at all?

steven jones’s picture

steven jones commented
Status: Needs review » Closed (duplicate)
Related issues: +#2960330: role/gid mapping refresh when gid missing (related to configuration synchronisation of content_access.settings and grey listing of roles with config_split)

Yeah, lets sort this in the same way as #2960330: role/gid mapping refresh when gid missing (related to configuration synchronisation of content_access.settings and grey listing of roles with config_split)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.