Closed (fixed)
Project:
Advanced CSS/JS Aggregation
Version:
7.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Jul 2020 at 07:39 UTC
Updated:
4 Nov 2020 at 18:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
aexchecker commentedComment #3
aexchecker commentedComment #4
kevin morse commentedLooks good to me.
I am also seeing this same notice a few other places
Notice: Trying to access array offset on value of type int in advagg_bundler_advagg_build_aggregate_plans_alter() (line 50 of /var/www/drupal7prod/sites/all/modules/advagg/advagg_bundler/advagg_bundler.advagg.inc).Notice: Trying to access array offset on value of type int in advagg_bundler_merge() (line 128 of /var/www/drupal7prod/sites/all/modules/advagg/advagg_bundler/advagg_bundler.advagg.inc).Notice: Trying to access array offset on value of type int in advagg_bundler_merge() (line 129 of /var/www/drupal7prod/sites/all/modules/advagg/advagg_bundler/advagg_bundler.advagg.inc).Comment #5
aexchecker commentedComment #6
aexchecker commentedComment #7
joelpittet@AexChecker It looks like your patch format is incorrect
This part shouldn't be in there, your IDE may need some tweaking to generate the patch.
Also some may be committed to the dev branch via #3145378: [PHP 7.4] Notice: Trying to access array offset on value of type int в функции advagg_modify_css_pre_render() (line 1554 file /advagg/advagg.module). and that's where you should generate your patch from.
Thanks for tackling this issue BTW!
Comment #8
ndewhurstHere is a patch against the latest 7.x-2.x code that only includes the second change (the first is covered by #3145378: [PHP 7.4] Notice: Trying to access array offset on value of type int в функции advagg_modify_css_pre_render() (line 1554 file /advagg/advagg.module).). We are actively using this.
Comment #9
thallesWhat is the steps to reproduce this bug!
Comment #10
othermachines commentedPath in #8 resolves this notice for me.
Comment #11
thallesSo I will put this like RTBC, based in #10
Comment #13
thalles