I got an error on the PHP 7.4.

Notice: Trying to access array offset on value of type int in advagg_modify_css_pre_render() (line 1554 of advagg.module).

Comments

AexChecker created an issue. See original summary.

aexchecker’s picture

StatusFileSize
new590 bytes
aexchecker’s picture

Status: Active » Needs review
kevin morse’s picture

Looks good to me.

I am also seeing this same notice a few other places

Notice: Trying to access array offset on value of type int in advagg_bundler_advagg_build_aggregate_plans_alter() (line 50 of /var/www/drupal7prod/sites/all/modules/advagg/advagg_bundler/advagg_bundler.advagg.inc).

Notice: Trying to access array offset on value of type int in advagg_bundler_merge() (line 128 of /var/www/drupal7prod/sites/all/modules/advagg/advagg_bundler/advagg_bundler.advagg.inc).

Notice: Trying to access array offset on value of type int in advagg_bundler_merge() (line 129 of /var/www/drupal7prod/sites/all/modules/advagg/advagg_bundler/advagg_bundler.advagg.inc).

aexchecker’s picture

StatusFileSize
new1.78 KB
aexchecker’s picture

Status: Needs review » Needs work
joelpittet’s picture

Version: 7.x-2.34 » 7.x-2.x-dev

@AexChecker It looks like your patch format is incorrect

This part shouldn't be in there, your IDE may need some tweaking to generate the patch.

	Index: advagg.module
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8

Also some may be committed to the dev branch via #3145378: [PHP 7.4] Notice: Trying to access array offset on value of type int в функции advagg_modify_css_pre_render() (line 1554 file /advagg/advagg.module). and that's where you should generate your patch from.

Thanks for tackling this issue BTW!

ndewhurst’s picture

Assigned: aexchecker » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.35 KB

Here is a patch against the latest 7.x-2.x code that only includes the second change (the first is covered by #3145378: [PHP 7.4] Notice: Trying to access array offset on value of type int в функции advagg_modify_css_pre_render() (line 1554 file /advagg/advagg.module).). We are actively using this.

thalles’s picture

What is the steps to reproduce this bug!

othermachines’s picture

Path in #8 resolves this notice for me.

thalles’s picture

Status: Needs review » Reviewed & tested by the community

So I will put this like RTBC, based in #10

  • thalles committed 798b29d on 7.x-2.x authored by ndewhurst
    Issue #3160952 by AexChecker, ndewhurst: [PHP 7.4] Notice: Trying to...
thalles’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.